Use ISO date strings for comparison

filiptronicek · geropl · web-flow · commit d8443e3b942c · 2025-01-31T10:02:13.000+01:00
Co-authored-by: Gero Posmyk-Leinemann &lt;gero@gitpod.io&gt;
diff --git a/components/server/src/workspace/workspace-service.ts b/components/server/src/workspace/workspace-service.ts
@@ -568,7 +568,7 @@ export class WorkspaceService {
                 daysToLive = daysToLive * 2;
             }
             deletionEligibilityTime.setDate(deletionEligibilityTime.getDate() + daysToLive);
-            if (new Date() > deletionEligibilityTime) {
+            if (new Date().toISOString() > deletionEligibilityTime.toISOString()) {
                 log.warn(
                     { userId, workspaceId, instanceId: instance?.id },
                     "[updateDeletionEligibilityTime] Prevented moving deletion eligibility time to the past",

Original file line number	Diff line number	Diff line change
`@@ -568,7 +568,7 @@ export class WorkspaceService {`
`568`	`568`	`daysToLive = daysToLive * 2;`
`569`	`569`	`}`
`570`	`570`	`deletionEligibilityTime.setDate(deletionEligibilityTime.getDate() + daysToLive);`
`571`		`- if (new Date() > deletionEligibilityTime) {`
	`571`	`+ if (new Date().toISOString() > deletionEligibilityTime.toISOString()) {`
`572`	`572`	`log.warn(`
`573`	`573`	`{ userId, workspaceId, instanceId: instance?.id },`
`574`	`574`	`"[updateDeletionEligibilityTime] Prevented moving deletion eligibility time to the past",`