test: always send events

Author: geropl

components/ws-manager-mk2/controllers/subscriber_controller.go

@@ -61,11 +61,11 @@ func (r *SubscriberReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 		workspace.Status.Conditions = []metav1.Condition{}
 	}
 
-	if workspace.IsConditionTrue(workspacev1.WorkspaceConditionPodRejected) {
-		// In this situation, we are about to re-create the pod. We don't want clients to see all the "stopping, stopped, starting" chatter, so we hide it here.
-		// TODO(gpl) Is this a sane approach?
-		return ctrl.Result{}, nil
-	}
+	// if workspace.IsConditionTrue(workspacev1.WorkspaceConditionPodRejected) {
+	// 	// In this situation, we are about to re-create the pod. We don't want clients to see all the "stopping, stopped, starting" chatter, so we hide it here.
+	// 	// TODO(gpl) Is this a sane approach?
+	// 	return ctrl.Result{}, nil
+	// }
 
 	if r.OnReconcile != nil {
 		r.OnReconcile(ctx, &workspace)

components/ws-manager-mk2/controllers/workspace_controller_test.go

@@ -532,7 +532,9 @@ var _ = Describe("WorkspaceController", func() {
 				recreations:    map[int]int{1: 1},
 			})
 
-			expectPhaseTransitions(su, []workspacev1.WorkspacePhase{workspacev1.WorkspacePhasePending, workspacev1.WorkspacePhaseCreating, workspacev1.WorkspacePhaseInitializing, workspacev1.WorkspacePhaseRunning})
+			// "Pending", "Unknown", "Stopping", "Stopped", "Pending", "Creating", "Initializing", "Running"
+			expectPhaseTransitions(su, []workspacev1.WorkspacePhase{workspacev1.WorkspacePhasePending, workspacev1.WorkspacePhaseUnknown, workspacev1.WorkspacePhaseStopping, workspacev1.WorkspacePhaseStopped, workspacev1.WorkspacePhasePending, workspacev1.WorkspacePhaseCreating, workspacev1.WorkspacePhaseInitializing, workspacev1.WorkspacePhaseRunning})
+			//expectPhaseTransitions(su, []workspacev1.WorkspacePhase{workspacev1.WorkspacePhasePending, workspacev1.WorkspacePhaseCreating, workspacev1.WorkspacePhaseInitializing, workspacev1.WorkspacePhaseRunning})
 			// ### validate end
 		})
 	})