Skip to content

Commit e4a1756

Browse files
committed
[bridge] Log nested status shape (and properly scrubbing it)
1 parent 42a0e3a commit e4a1756

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

components/ws-manager-bridge/src/bridge.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
DescribeClusterRequest,
2424
WorkspaceType,
2525
} from "@gitpod/ws-manager/lib";
26-
import { TrustedValue } from "@gitpod/gitpod-protocol/lib/util/scrubbing";
26+
import { scrubber, TrustedValue } from "@gitpod/gitpod-protocol/lib/util/scrubbing";
2727
import { WorkspaceDB } from "@gitpod/gitpod-db/lib/workspace-db";
2828
import { log, LogContext } from "@gitpod/gitpod-protocol/lib/util/logging";
2929
import { TraceContext } from "@gitpod/gitpod-protocol/lib/util/tracing";
@@ -193,7 +193,7 @@ export class WorkspaceManagerBridge implements Disposable {
193193
) {
194194
const start = performance.now();
195195
const status = rawStatus.toObject();
196-
log.info("Handling WorkspaceStatus update", filterStatus(status));
196+
log.info("Handling WorkspaceStatus update", { status: new TrustedValue(filterStatus(status)) });
197197

198198
if (!status.spec || !status.metadata || !status.conditions) {
199199
log.warn("Received invalid status update", status);
@@ -462,11 +462,11 @@ const mapPortProtocol = (protocol: WsManPortProtocol): PortProtocol => {
462462
export const filterStatus = (status: WorkspaceStatus.AsObject): Partial<WorkspaceStatus.AsObject> => {
463463
return {
464464
id: status.id,
465-
metadata: status.metadata,
465+
metadata: scrubber.scrub(status.metadata),
466466
phase: status.phase,
467467
message: status.message,
468-
conditions: new TrustedValue(status.conditions).value,
469-
runtime: new TrustedValue(status.runtime).value,
468+
conditions: status.conditions,
469+
runtime: status.runtime,
470470
};
471471
};
472472

0 commit comments

Comments
 (0)