Skip to content

Commit eefd3cf

Browse files
committed
Fix things
1 parent 25ec9e9 commit eefd3cf

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

components/gitpod-db/src/typeorm/migration/1736951418625-AddOrgSettingsCommitAnnotation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { MigrationInterface, QueryRunner } from "typeorm";
88
import { columnExists } from "./helper/helper";
99

1010
const table = "d_b_org_settings";
11-
const newColumn = "annotateCommits";
11+
const newColumn = "annotateGitCommits";
1212

1313
export class AddOrgSettingsCommitAnnotation1736951418625 implements MigrationInterface {
1414
public async up(queryRunner: QueryRunner): Promise<void> {

components/server/src/orgs/organization-service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -599,8 +599,8 @@ export class OrganizationService {
599599
if (settings.onboardingSettings) {
600600
result.onboardingSettings = settings.onboardingSettings;
601601
}
602-
if (settings.annotateCommits) {
603-
result.annotateCommits = settings.annotateCommits;
602+
if (settings.annotateGitCommits) {
603+
result.annotateGitCommits = settings.annotateGitCommits;
604604
}
605605

606606
return result;

components/server/src/workspace/workspace-starter.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1562,6 +1562,12 @@ export class WorkspaceStarter {
15621562
sysEnvvars.push(ev);
15631563
}
15641564

1565+
const organizationSettings = await this.orgService.getSettings(user.id, workspace.organizationId);
1566+
organizationSettings.annotateGitCommits;
1567+
sysEnvvars.push(
1568+
newEnvVar("GITPOD_COMMIT_ANNOTATION_ENABLED", organizationSettings.annotateGitCommits ? "true" : "false"),
1569+
);
1570+
15651571
const orgIdEnv = new EnvironmentVariable();
15661572
orgIdEnv.setName("GITPOD_DEFAULT_WORKSPACE_IMAGE");
15671573
orgIdEnv.setValue(await this.configProvider.getDefaultImage(workspace.organizationId));
@@ -1582,7 +1588,6 @@ export class WorkspaceStarter {
15821588
sysEnvvars.push(isSetJavaXmx);
15831589
sysEnvvars.push(isSetJavaProcessorCount);
15841590
sysEnvvars.push(disableJetBrainsLocalPortForwarding);
1585-
sysEnvvars.push(newEnvVar("GITPOD_COMMIT_ANNOTATION_ENABLED", "true"));
15861591
const spec = new StartWorkspaceSpec();
15871592
await createGitpodTokenPromise;
15881593
spec.setEnvvarsList(envvars);
@@ -1609,7 +1614,6 @@ export class WorkspaceStarter {
16091614
spec.setTimeout(defaultTimeout);
16101615
spec.setMaximumLifetime(workspaceLifetime);
16111616
if (allowSetTimeout) {
1612-
const organizationSettings = await this.orgService.getSettings(user.id, workspace.organizationId);
16131617
if (organizationSettings.timeoutSettings?.inactivity) {
16141618
try {
16151619
const timeout = WorkspaceTimeoutDuration.validate(

0 commit comments

Comments
 (0)