Introduce a magic constant instead of empty strings

Author: filiptronicek

components/server/src/repohost/file-provider.ts

@@ -14,6 +14,7 @@ export class RevisionNotFoundError extends Error {
         this.name = "RevisionNotFoundError";
     }
 }
+export const ImageFileRevisionMissing = "ImageFileRevisionMissing";
 
 export const FileProvider = Symbol("FileProvider");
 export interface FileProvider {

components/server/src/workspace/config-provider.ts

@@ -33,7 +33,7 @@ import { Config } from "../config";
 import { EntitlementService } from "../billing/entitlement-service";
 import { TeamDB } from "@gitpod/gitpod-db/lib";
 import { InvalidGitpodYMLError } from "@gitpod/public-api-common/lib/public-api-errors";
-import { RevisionNotFoundError } from "../repohost";
+import { ImageFileRevisionMissing, RevisionNotFoundError } from "../repohost";
 
 const POD_PATH_WORKSPACE_BASE = "/workspace";
 
@@ -263,7 +263,7 @@ export class ConfigProvider {
                 .getLastChangeRevision(repository, revisionOrTagOrBranch, user, dockerFilePath)
                 .catch((e) => {
                     if (e instanceof RevisionNotFoundError) {
-                        return "";
+                        return ImageFileRevisionMissing;
                     }
                     throw e;
                 });

components/server/src/workspace/context-parser-service.ts

@@ -19,6 +19,7 @@ import { TraceContext } from "@gitpod/gitpod-protocol/lib/util/tracing";
 import { ConfigProvider } from "./config-provider";
 import { InvalidGitpodYMLError } from "@gitpod/public-api-common/lib/public-api-errors";
 import { ApplicationError, ErrorCodes } from "@gitpod/gitpod-protocol/lib/messaging/error";
+import { ImageFileRevisionMissing } from "../repohost";
 
 @injectable()
 export class ContextParser {
@@ -191,7 +192,7 @@ export class ContextParser {
             }
 
             if (ExternalImageConfigFile.is(config.config.image)) {
-                if (config.config.image.externalSource.revision === "") {
+                if (config.config.image.externalSource.revision === ImageFileRevisionMissing) {
                     context.warnings.push("The Dockerfile specified in the .gitpod.yml file was not found.");
                 }
             }

components/server/src/workspace/image-source-provider.ts

@@ -19,7 +19,7 @@ import {
     AdditionalContentContext,
 } from "@gitpod/gitpod-protocol";
 import { createHash } from "crypto";
-import { RevisionNotFoundError } from "../repohost";
+import { ImageFileRevisionMissing, RevisionNotFoundError } from "../repohost";
 
 @injectable()
 export class ImageSourceProvider {
@@ -48,7 +48,7 @@ export class ImageSourceProvider {
                     .getLastChangeRevision(repository, imgcfg.externalSource.revision, user, imgcfg.file)
                     .catch((e) => {
                         if (e instanceof RevisionNotFoundError) {
-                            return "";
+                            return ImageFileRevisionMissing;
                         }
                         throw e;
                     });
@@ -79,7 +79,7 @@ export class ImageSourceProvider {
                     .getLastChangeRevision(context.repository, context.revision, user, imgcfg.file)
                     .catch((e) => {
                         if (e instanceof RevisionNotFoundError) {
-                            return "";
+                            return ImageFileRevisionMissing;
                         }
                         throw e;
                     });