Skip to content

Prebuild trigger checks #20228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 23, 2024
Merged

Prebuild trigger checks #20228

merged 16 commits into from
Sep 23, 2024

Conversation

@filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Sep 17, 2024 •
edited
Loading

Description

This change introduces the following functionality around activity-based prebuilds:

  • Adds a warning for repositories that have received a webhook event for the most recent commit about considering an update to activity-based prebuilds
  • Automatically changes prebuild trigger strategy from activity-based to webhook-based when we receive a webhook event
  • Automatically changes prebuild trigger strategy from webhook-based to activity-based when creating a workspace and the repository not sending a webhook push event for the last commit

Related Issue(s)

Fixes ENT-601

How to test

https://ft-webhook870fa6143a.preview.gitpod-dev.com/workspaces

  1. Import a repo
  2. Enable prebuilds on it
  3. See warning
  4. Remove the webhook and push a new commit
  5. Observe that the warning disappears

@filiptronicek filiptronicek force-pushed the ft/webhook-prebuilds-checks branch from 967dea7 to b2ef975 Compare September 17, 2024 17:04
@filiptronicek filiptronicek marked this pull request as ready for review September 17, 2024 21:09
@filiptronicek filiptronicek requested review from a team as code owners September 17, 2024 21:09
@filiptronicek filiptronicek self-assigned this Sep 17, 2024
geropl
geropl reviewed Sep 18, 2024
View reviewed changes
geropl
geropl reviewed Sep 18, 2024
View reviewed changes
geropl
geropl reviewed Sep 18, 2024
View reviewed changes
@geropl
Copy link
Member

geropl commented Sep 18, 2024

@filiptronicek It would be great to align on the goals in sync. I feel I'm a bit lost on the "make webhook the new/old" default, but might also be mis-reading things. 👍

geropl
geropl approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works! ✔️

(please revert the debug commit before merge 😇 )

@roboquat roboquat merged commit cfe795c into main Sep 23, 2024
18 checks passed
@roboquat roboquat deleted the ft/webhook-prebuilds-checks branch September 23, 2024 13:00
@filiptronicek filiptronicek mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geropl geropl geropl approved these changes

Assignees

@filiptronicek filiptronicek

Labels

size/XL team: team-enterprise team: team-experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filiptronicek @geropl @roboquat