Repository finder & context parsing improvements #20296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Oct 13, 2024
|
|
||
| const setActiveElement = useCallback( | ||
| (element: string) => { | ||
| if (!filteredOptions.find((el) => element === el.id)?.isSelectable) { |
There was a problem hiding this comment.
This was a weird bug in which you could select the Bitbucket server help message as a context URL by clicking on it with your pointer and pressing Enter
jeanp413
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes bad requests against our context parser, no longer page folks.
Related Issue(s)
Fixes https://gitpod.slack.com/archives/C01TNS8EVQT/p1728825373116179
How to test
ParseContextURLshould respond with a 400 and not a 500 in the network tab of DevTools.