Skip to content

[dashboard] Add a notice of Prebuild GC to the prebuilds list #20317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[dashboard] Add a notice of Prebuild GC to the prebuilds list #20317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 28 additions & 16 deletions components/dashboard/src/prebuilds/list/PrebuildList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

import { useCallback, useEffect, useMemo, useState } from "react";
import { useHistory } from "react-router-dom";
import { Link, useHistory } from "react-router-dom";
import { useQueryParams } from "../../hooks/use-query-params";
import { PrebuildListEmptyState } from "./PrebuildListEmptyState";
import { PrebuildListErrorState } from "./PrebuildListErrorState";
Expand Down Expand Up @@ -175,21 +175,33 @@ export const PrebuildsList = ({ initialFilter, organizationId, hideOrgSpecificCo
{isLoading && <LoadingState />}

{showTable && (
<PrebuildsTable
prebuilds={prebuilds}
// we check isPreviousData too so we don't show spinner if it's a background refresh
isSearching={isFetching && isPreviousData}
isFetchingNextPage={isFetchingNextPage}
hasNextPage={!!hasNextPage}
filter={filter}
sort={sort}
hasMoreThanOnePage={hasMoreThanOnePage}
hideOrgSpecificControls={!!hideOrgSpecificControls}
onLoadNextPage={() => fetchNextPage()}
onFilterChange={handleFilterChange}
onSort={handleSort}
onTriggerPrebuild={() => setShowRunPrebuildModal(true)}
/>
<>
<PrebuildsTable
prebuilds={prebuilds}
// we check isPreviousData too so we don't show spinner if it's a background refresh
isSearching={isFetching && isPreviousData}
isFetchingNextPage={isFetchingNextPage}
hasNextPage={!!hasNextPage}
filter={filter}
sort={sort}
hasMoreThanOnePage={hasMoreThanOnePage}
hideOrgSpecificControls={!!hideOrgSpecificControls}
onLoadNextPage={() => fetchNextPage()}
onFilterChange={handleFilterChange}
onSort={handleSort}
onTriggerPrebuild={() => setShowRunPrebuildModal(true)}
/>
<div className="flex justify-center mt-4">
<span className="text-pk-content-secondary text-xs max-w-md text-center">
Looking for older prebuilds? Prebuilds are garbage-collected if no workspace is started from
them within seven days. To view records of older prebuilds, please refer to the{" "}
<Link to={"/usage"} className="gp-link">
usage report
</Link>
.
</span>
</div>
</>
)}

{showRunPrebuildModal && (
Expand Down
21 changes: 11 additions & 10 deletions components/dashboard/src/prebuilds/list/PrebuildTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,16 +132,17 @@ export const PrebuildsTable: FC<Props> = ({
<Subheading className="max-w-md">No results found. Try adjusting your search terms.</Subheading>
</div>
)}

<div className="mt-4 mb-8 flex flex-row justify-center">
{hasNextPage ? (
<LoadingButton variant="secondary" onClick={onLoadNextPage} loading={isFetchingNextPage}>
Load more
</LoadingButton>
) : (
hasMoreThanOnePage && <TextMuted>All prebuilds are loaded</TextMuted>
)}
</div>
{prebuilds.length > 1 && (
<div className="mt-4 mb-8 flex flex-row justify-center">
{hasNextPage ? (
<LoadingButton variant="secondary" onClick={onLoadNextPage} loading={isFetchingNextPage}>
Load more
</LoadingButton>
) : (
hasMoreThanOnePage && <TextMuted>All prebuilds are loaded</TextMuted>
)}
</div>
)}
</div>
</>
);
Expand Down
Loading