From 8f5c797f27eb4b121ee4bd09b2510fcaae683dd1 Mon Sep 17 00:00:00 2001 From: Robo Quat Date: Wed, 6 Nov 2024 11:00:39 +0000 Subject: [PATCH 1/3] Update Platform Version of JetBrains Gateway Plugin (EAP) to --- .../ide/jetbrains/gateway-plugin/gradle-latest.properties | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/ide/jetbrains/gateway-plugin/gradle-latest.properties b/components/ide/jetbrains/gateway-plugin/gradle-latest.properties index 556e5d3b2e9cbf..f81541caec17ef 100644 --- a/components/ide/jetbrains/gateway-plugin/gradle-latest.properties +++ b/components/ide/jetbrains/gateway-plugin/gradle-latest.properties @@ -2,10 +2,10 @@ # See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html # for insight into build numbers and IntelliJ Platform versions. # revert pluginSinceBuild if it's unnecessary -pluginSinceBuild=243.18137 +pluginSinceBuild=243.21155 pluginUntilBuild=243.* # Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl # See https://jb.gg/intellij-platform-builds-list for available build versions. pluginVerifierIdeVersions=2024.3 -# Version from "com.jetbrains.gateway" which can be found at https://www.jetbrains.com/intellij-repository/snapshots -platformVersion=243.18137.22 +# Version from "com.jetbrains.gateway" which can be found at https://www.jetbrains.com/updates/updates.xml or exec `./gradlew printProductsReleases` +platformVersion=243.21155.27 From 9497947d11182dbd9c64967881e4fe49ebde6049 Mon Sep 17 00:00:00 2001 From: Huiwen Date: Wed, 6 Nov 2024 18:20:17 +0000 Subject: [PATCH 2/3] Revert gradle properties changes --- .../ide/jetbrains/gateway-plugin/gradle-latest.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/ide/jetbrains/gateway-plugin/gradle-latest.properties b/components/ide/jetbrains/gateway-plugin/gradle-latest.properties index f81541caec17ef..a0038e80726356 100644 --- a/components/ide/jetbrains/gateway-plugin/gradle-latest.properties +++ b/components/ide/jetbrains/gateway-plugin/gradle-latest.properties @@ -2,7 +2,7 @@ # See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html # for insight into build numbers and IntelliJ Platform versions. # revert pluginSinceBuild if it's unnecessary -pluginSinceBuild=243.21155 +pluginSinceBuild=243.18137 pluginUntilBuild=243.* # Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl # See https://jb.gg/intellij-platform-builds-list for available build versions. From d17b97ada99db2b3b7c14a55cd44073f945406a7 Mon Sep 17 00:00:00 2001 From: Huiwen Date: Wed, 6 Nov 2024 18:23:15 +0000 Subject: [PATCH 3/3] Address Filip's feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit https://github.com/gitpod-io/gitpod/pull/20319#discussion_r1828975604 Co-authored-by: Filip Troníček --- .../io/gitpod/jetbrains/gateway/GitpodSettingsConfigurable.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/ide/jetbrains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodSettingsConfigurable.kt b/components/ide/jetbrains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodSettingsConfigurable.kt index 6f56276a380692..fdd3ee4d5b9bfa 100644 --- a/components/ide/jetbrains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodSettingsConfigurable.kt +++ b/components/ide/jetbrains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodSettingsConfigurable.kt @@ -34,7 +34,7 @@ class GitpodSettingsConfigurable : BoundConfigurable("Gitpod") { row { checkBox("Persistent connection heartbeats") .bindSelected(state::additionalHeartbeat) - .comment("Keep workspaces running as long as the IDE connection remains active.") + .comment("Keep workspaces running as long as the IDE connection remains active") } }