[server] Fix permission check for logs streaming #20423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an oopsie I made in #20353 regarding permission checks. The change was supposed to unblock collaborators so that they can stream prebuild logs leveraging their permissions on the project level (in contrast to organization level), but I forgot to update the argument we pass to
checkPermissionOnProjectto be theprojectIdinstead of theorganizationIdthat was there before.Related Issue(s)
Fixes CLC-1011
How to test
There's a preview env: https://ft-fix-prebuilds.preview.gitpod-dev.com/prebuilds/
You can join my org and look at this prebuild to confirm streaming works again.
/hold