Skip to content

[dashboard] Fix bottom page margins for Prebuilds, Repositories and Insights #20455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[dashboard] Fix bottom page margins for Prebuilds, Repositories and Insights #20455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90b6303
[dashboard] Fix bottom page margins for Prebuilds, Repositories and I…
filiptronicek Dec 16, 2024
67b84fc
Fix `/insights` as well
filiptronicek Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/dashboard/src/Insights.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const Insights = () => {
return (
<>
<Header title="Insights" subtitle="Insights into workspace sessions in your organization" />
<div className="app-container pt-5">
<div className="app-container pt-5 pb-8">
<div
className={classNames(
"flex flex-col items-start space-y-3 justify-between",
Expand Down Expand Up @@ -142,7 +142,7 @@ export const Insights = () => {
</ItemsList>
</div>

<div className="mt-4 mb-8 flex flex-row justify-center">
<div className="mt-4 flex flex-row justify-center">
{hasNextPage ? (
<LoadingButton
variant="secondary"
Expand Down
2 changes: 1 addition & 1 deletion components/dashboard/src/prebuilds/list/PrebuildListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const PrebuildListPage = () => {
useDocumentTitle("Prebuilds");

return (
<div className="app-container mb-8">
<div className="app-container pb-8">
<PageHeading title="Prebuilds" subtitle="Review prebuilds of your added repositories." />
<PrebuildsList />
</div>
Expand Down
2 changes: 1 addition & 1 deletion components/dashboard/src/repositories/list/RepositoryList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const RepositoryListPage: FC = () => {

return (
<>
<div className="app-container mb-8">
<div className="app-container pb-8">
<PageHeading
title="Repository settings"
subtitle="Configure and refine the experience of working with a repository in Gitpod."
Expand Down
2 changes: 1 addition & 1 deletion components/dashboard/src/repositories/list/RepositoryTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export const RepositoryTable: FC<Props> = ({
</div>
)}

<div className="mt-4 mb-8 flex flex-row justify-center">
<div className="mt-4 flex flex-row justify-center">
{hasNextPage ? (
<LoadingButton variant="secondary" onClick={onLoadNextPage} loading={isFetchingNextPage}>
Load more
Expand Down
Loading