[dashboard] team setting design polish + more consistent color use #20547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Jan 24, 2025
Member
Author
There was a problem hiding this comment.
Changes here were done to align with our Figma doc for Podkit components
geropl
approved these changes
Jan 24, 2025
Member
geropl
left a comment
geropl
left a comment
There was a problem hiding this comment.
Thank for the polish! Could immediately spot a couple of places, and in dark-mode it's even more pronounced 💅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some small nits in the organization settings pages and also adds our adaptive Podkit colors (
pk-content-*andpk-surface-*) to improve readability - these colors adapt to both light and dark modes, so the resulting markup is way shorter and actually communicates intent, rather than an arbitrary color value (liketext-gray-400).Related Issue(s)
Fixes CLC-1097
How to test
Check it out on https://ft-color-fixes.preview.gitpod-dev.com/workspaces. There are some places with improved contrast (like the new organization button), but mostly changes are in code rather than actual design.
Here's the example of the new org button in dark mode:
/hold