Skip to content

[dashboard] Don't show User Notifications and Feedback on Dedicated #20583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2025
Merged

[dashboard] Don't show User Notifications and Feedback on Dedicated #20583

merged 5 commits into from
Feb 7, 2025

Conversation

@filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Feb 6, 2025 •
edited
Loading

Description

This PR:

  • disables the "Notifications" tab in user settings for Dedicated installations, because there we don't send any emails to our users
  • gets rid of the Feedback button in the top navbar for dedicated-emulated preview environments

How to test

  1. Go to the preview env: (it has dedicated emulation on) https://ft-bring-p79b5247b4c.preview.gitpod-dev.com/user/account
  2. VIsit the user settings and confirm there's no "Notifications" tab
  3. Look at the top navbar and confirm there's no Feedback

/hold

@filiptronicek
fix import
e811a1a 
Tool: gitpod/catfood.gitpod.cloud
@filiptronicek
Fixe-da-imports-a
0d828f3 
Tool: gitpod/catfood.gitpod.cloud
@filiptronicek
Fix second place where Feedback menu item appears
5c78b06 
Tool: gitpod/catfood.gitpod.cloud
@filiptronicek
Merge remote-tracking branch 'origin/main' into ft/bring-preview-envs…
5ecb65b 
…-closer-to-prod

Tool: gitpod/catfood.gitpod.cloud
@filiptronicek filiptronicek marked this pull request as ready for review February 7, 2025 16:27
@filiptronicek filiptronicek requested review from a team as code owners February 7, 2025 16:27
geropl
geropl approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works! ✔️

@filiptronicek filiptronicek self-assigned this Feb 7, 2025
@roboquat roboquat merged commit fb89d41 into main Feb 7, 2025
20 checks passed
@roboquat roboquat deleted the ft/bring-preview-envs-closer-to-prod branch February 7, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geropl geropl geropl approved these changes

Assignees

@filiptronicek filiptronicek

Labels

size/M team: team-enterprise team: team-experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@filiptronicek @geropl @roboquat