[server] add feature flags for spicedb client options #20613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool: gitpod/catfood.gitpod.cloud
mustard-mh
force-pushed
the
hw/CLC-370
branch
from
750adeb to
b45b492
Compare
Tool: gitpod/catfood.gitpod.cloud
Member
|
@mustard-mh because the API calls on the preview environment seem to be succeeding, I assume SpiceDB is doing fine. Could you update the description in the PR or in Linear to outline:
|
Contributor
Author
|
Thanks @filiptronicek , this PR is related to this internal chat that we want to try different grpc options.
Not sure |
filiptronicek
approved these changes
Feb 24, 2025
Member
filiptronicek
left a comment
filiptronicek
left a comment
There was a problem hiding this comment.
@mustard-mh I see, thanks for sharing. I don't have anything against this, so unblocking.
Member
|
Rage-clicked LGTM here, so you get two approvals :P |
geropl
reviewed
Feb 24, 2025
geropl
reviewed
Feb 24, 2025
geropl
reviewed
Feb 24, 2025
geropl
reviewed
Feb 24, 2025
geropl
reviewed
Feb 24, 2025
Co-authored-by: Gero Posmyk-Leinemann <[email protected]> Tool: gitpod/catfood.gitpod.cloud
Contributor
Author
|
@geropl feedback addressed, could you take a look again? |
Member
Looks great, let's merge! 🚀 |
Member
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[server] add feature flags for spicedb client options
The default value of the feature flag is
undefined. If the feature flag is set to this value, we will use the default spicedb grpc client options, otherwise the value should be a valid json.Related Issue(s)
Relates CLC-370 (internal chat)
How to test
JSON.stringifygrpc client optionsDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold