[ws-proxy] fix leak idle connection cache #20857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: team-engine
team: team-enterprise
and removed
size/M
labels
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes HTTP transport creation to prevent idle connection leaks by reusing a single transport instance with customizable options.
- Introduce
createDefaultTransportwith variadiccreateHttpTransportOptand awithSkipTLSVerifyoption. - Replace inline
http.Transportinstantiation in routes with a reusedportTransport. - Remove direct
tls.Configsetup in favor of the new transport option pattern.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| components/ws-proxy/pkg/proxy/routes.go | Define and reuse portTransport via createDefaultTransport |
| components/ws-proxy/pkg/proxy/pass.go | Add createHttpTransportOpt, withSkipTLSVerify, and update transport constructor |
Comments suppressed due to low confidence (5)
components/ws-proxy/pkg/proxy/pass.go:225
- [nitpick] Consider renaming 'withSkipTLSVerify' to 'skipTLSVerifyOpt' or similar to align with the 'XxxOpt' naming convention for option functions.
func withSkipTLSVerify() createHttpTransportOpt {
components/ws-proxy/pkg/proxy/pass.go:233
- There are no unit tests for 'createDefaultTransport' or its options; add tests to verify that 'withSkipTLSVerify' and timeout settings are applied correctly.
func createDefaultTransport(config *TransportConfig, opts ...createHttpTransportOpt) http.RoundTripper {
components/ws-proxy/pkg/proxy/routes.go:534
- [nitpick] The variable name 'portTransport' may be ambiguous; consider renaming to 'wsPortTransport' or 'defaultPortTransport' to clarify its purpose.
portTransport := createDefaultTransport(config.Config.TransportConfig, withSkipTLSVerify())
components/ws-proxy/pkg/proxy/pass.go:41
- The comment has grammatical issues; consider rephrasing to 'createHttpTransportOpt allows composing HTTP transport options.'
// createHttpTransportOpt allows to compose create http Transport options.
components/ws-proxy/pkg/proxy/pass.go:233
- Add a comment describing the parameters of 'createDefaultTransport' and how the variadic options are applied to improve maintainability.
func createDefaultTransport(config *TransportConfig, opts ...createHttpTransportOpt) http.RoundTripper {
Contributor
|
👋 @iQQBot I'll take a look right now |
geropl
reviewed
May 28, 2025
Member
|
Thank you @iQQBot for crushing once again! 🚀 |
Contributor
Author
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ws-proxy] fix leak idle connection cache
Related Issue(s)
Fixes CLC-1392
How to test
conntrack -L | grep 28832for observeDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold