Merge pull request microsoft#166616 from amunger/attachmentCleaner

amunger · web-flow · commit 0043f98f037a · 2022-11-17T10:48:26.000-08:00
don't clean attachments for a cell that is removed
diff --git a/extensions/ipynb/src/notebookAttachmentCleaner.ts b/extensions/ipynb/src/notebookAttachmentCleaner.ts
@@ -187,7 +187,7 @@ export class AttachmentCleaner implements vscode.CodeActionProvider {
 			}
 		}
 
-		if (!objectEquals(markdownAttachmentsInUse, cell.metadata.attachments)) {
+		if (cell.index > -1 && !objectEquals(markdownAttachmentsInUse, cell.metadata.attachments)) {
 			const updateMetadata: { [key: string]: any } = deepClone(cell.metadata);
 			updateMetadata.attachments = markdownAttachmentsInUse;
 			const metadataEdit = vscode.NotebookEdit.updateCellMetadata(cell.index, updateMetadata);

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ export class AttachmentCleaner implements vscode.CodeActionProvider {`
`187`	`187`	`}`
`188`	`188`	`}`
`189`	`189`
`190`		`- if (!objectEquals(markdownAttachmentsInUse, cell.metadata.attachments)) {`
	`190`	`+ if (cell.index > -1 && !objectEquals(markdownAttachmentsInUse, cell.metadata.attachments)) {`
`191`	`191`	`const updateMetadata: { [key: string]: any } = deepClone(cell.metadata);`
`192`	`192`	`updateMetadata.attachments = markdownAttachmentsInUse;`
`193`	`193`	`const metadataEdit = vscode.NotebookEdit.updateCellMetadata(cell.index, updateMetadata);`