Skip to content

Commit 0049376

Browse files
authored
Merge pull request microsoft#180985 from microsoft/merogge/diff
set `diffEditor` verbose to false by default
2 parents 9f86a45 + b44d1fb commit 0049376

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/vs/editor/browser/widget/diffEditorWidget.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ export class DiffEditorWidget extends Disposable implements editorBrowser.IDiffE
286286
renderOverviewRuler: true,
287287
diffWordWrap: 'inherit',
288288
diffAlgorithm: 'advanced',
289-
accessibilityVerbose: true
289+
accessibilityVerbose: false
290290
});
291291

292292
if (typeof options.isInEmbeddedEditor !== 'undefined') {
@@ -2796,6 +2796,7 @@ function changedDiffEditorOptions(a: ValidDiffEditorBaseOptions, b: ValidDiffEdi
27962796
renderOverviewRuler: (a.renderOverviewRuler !== b.renderOverviewRuler),
27972797
diffWordWrap: (a.diffWordWrap !== b.diffWordWrap),
27982798
diffAlgorithm: (a.diffAlgorithm !== b.diffAlgorithm),
2799+
accessibilityVerbose: (a.accessibilityVerbose !== b.accessibilityVerbose),
27992800
};
28002801
}
28012802

src/vs/workbench/contrib/notebook/browser/diff/diffComponents.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -502,8 +502,7 @@ abstract class AbstractElementRenderer extends Disposable {
502502
dimension: {
503503
height: this.cell.layoutInfo.metadataHeight,
504504
width: this.cell.getComputedCellContainerWidth(this.notebookEditor.getLayoutInfo(), true, true)
505-
},
506-
accessibilityVerbose: this.configurationService.getValue<boolean>('accessibility.verbosity.diff-editor') ?? false
505+
}
507506
}, {
508507
originalEditor: getOptimizedNestedCodeEditorWidgetOptions(),
509508
modifiedEditor: getOptimizedNestedCodeEditorWidgetOptions()
@@ -615,7 +614,8 @@ abstract class AbstractElementRenderer extends Disposable {
615614
dimension: {
616615
height: Math.min(OUTPUT_EDITOR_HEIGHT_MAGIC, this.cell.layoutInfo.rawOutputHeight || lineHeight * lineCount),
617616
width: this.cell.getComputedCellContainerWidth(this.notebookEditor.getLayoutInfo(), false, true)
618-
}
617+
},
618+
accessibilityVerbose: this.configurationService.getValue<boolean>('accessibility.verbosity.diff-editor') ?? false
619619
}, {
620620
originalEditor: getOptimizedNestedCodeEditorWidgetOptions(),
621621
modifiedEditor: getOptimizedNestedCodeEditorWidgetOptions()

0 commit comments

Comments
 (0)