Kernel picker type: all/mru. (microsoft#166523)

Author: rebornix

src/vs/workbench/contrib/notebook/browser/notebook.contribution.ts

@@ -910,11 +910,16 @@ configurationRegistry.registerConfiguration({
 			type: 'string',
 			tags: ['notebookLayout']
 		},
-		[NotebookSetting.kernelPickerMRU]: {
-			markdownDescription: nls.localize('notebook.kernelPickerMRU', "Controls whether the kernel picker should show the most recently used kernels."),
-			type: 'boolean',
+		[NotebookSetting.kernelPickerType]: {
+			markdownDescription: nls.localize('notebook.kernelPickerType', "Controls the type of kernel picker to use."),
+			type: 'string',
+			enum: ['all', 'mru'],
+			enumDescriptions: [
+				nls.localize('notebook.kernelPickerType.all', "Show all kernels."),
+				nls.localize('notebook.kernelPickerType.mru', "Experiment: show recently used kernels."),
+			],
 			tags: ['notebookLayout'],
-			default: false
+			default: 'all'
 		}
 	}
 });

src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelView.ts

@@ -80,9 +80,9 @@ registerAction2(class extends Action2 {
 		const instantiationService = accessor.get(IInstantiationService);
 		const configurationService = accessor.get(IConfigurationService);
 
-		const usingMru = configurationService.getValue<boolean>('notebook.experimental.kernelPicker.mru');
+		const kernelPickerType = configurationService.getValue<'all' | 'mru'>('notebook.kernelPicker.type');
 
-		if (usingMru) {
+		if (kernelPickerType === 'mru') {
 			const strategy = instantiationService.createInstance(KernelPickerMRUStrategy);
 			return await strategy.showQuickPick(context);
 		} else {
@@ -139,8 +139,8 @@ export class NotebooKernelActionViewItem extends ActionViewItem {
 			return;
 		}
 
-		const usingMru = this._configurationService.getValue<boolean>('notebook.experimental.kernelPicker.mru');
-		if (usingMru) {
+		const kernelPickerType = this._configurationService.getValue<'all' | 'mru'>('notebook.kernelPicker.type');
+		if (kernelPickerType === 'mru') {
 			KernelPickerMRUStrategy.updateKernelStatusAction(notebook, this._action, this._notebookKernelService);
 		} else {
 			KernelPickerFlatStrategy.updateKernelStatusAction(notebook, this._action, this._notebookKernelService, this._editor.scopedContextKeyService);

src/vs/workbench/contrib/notebook/common/notebookCommon.ts

@@ -926,7 +926,7 @@ export const NotebookSetting = {
 	outputLineHeight: 'notebook.outputLineHeight',
 	outputFontSize: 'notebook.outputFontSize',
 	outputFontFamily: 'notebook.outputFontFamily',
-	kernelPickerMRU: 'notebook.experimental.kernelPicker.mru'
+	kernelPickerType: 'notebook.kernelPicker.type'
 } as const;
 
 export const enum CellStatusbarAlignment {