Merge pull request microsoft#138428 from microsoft/roblou/fixCellEditorFocus

roblourens · web-flow · commit 022e0abc0bf7 · 2021-12-06T11:23:21.000-08:00
Always fire onDidChangeState when focusMode is set
diff --git a/src/vs/workbench/contrib/notebook/browser/viewModel/baseCellViewModel.ts b/src/vs/workbench/contrib/notebook/browser/viewModel/baseCellViewModel.ts
@@ -104,10 +104,8 @@ export abstract class BaseCellViewModel extends Disposable {
 		return this._focusMode;
 	}
 	set focusMode(newMode: CellFocusMode) {
-		if (this._focusMode !== newMode) {
-			this._focusMode = newMode;
-			this._onDidChangeState.fire({ focusModeChanged: true });
-		}
+		this._focusMode = newMode;
+		this._onDidChangeState.fire({ focusModeChanged: true });
 	}
 
 	protected _textEditor?: ICodeEditor;

Original file line number	Diff line number	Diff line change
`@@ -104,10 +104,8 @@ export abstract class BaseCellViewModel extends Disposable {`
`104`	`104`	`return this._focusMode;`
`105`	`105`	`}`
`106`	`106`	`set focusMode(newMode: CellFocusMode) {`
`107`		`- if (this._focusMode !== newMode) {`
`108`		`- this._focusMode = newMode;`
`109`		`- this._onDidChangeState.fire({ focusModeChanged: true });`
`110`		`- }`
	`107`	`+ this._focusMode = newMode;`
	`108`	`+ this._onDidChangeState.fire({ focusModeChanged: true });`
`111`	`109`	`}`
`112`	`110`
`113`	`111`	`protected _textEditor?: ICodeEditor;`