Manage prompt files: copy (microsoft#250301)

* manage prompt files: copy

* fix comments

Author: aeschli

src/vs/workbench/contrib/chat/browser/actions/promptActions/dialogs/askToSelectPrompt/promptFilePickers.ts

@@ -23,6 +23,7 @@ import { IKeyMods, IQuickInputButton, IQuickInputService, IQuickPick, IQuickPick
 import { askForPromptFileName } from '../../../../promptSyntax/contributions/createPromptCommand/dialogs/askForPromptName.js';
 import { IInstantiationService } from '../../../../../../../../platform/instantiation/common/instantiation.js';
 import { CancellationToken } from '../../../../../../../../base/common/cancellation.js';
+import { askForPromptSourceFolder } from '../../../../promptSyntax/contributions/createPromptCommand/dialogs/askForPromptSourceFolder.js';
 
 /**
  * Options for the {@link askToSelectInstructions} function.
@@ -47,6 +48,7 @@ export interface ISelectOptions {
 	readonly optionEdit?: boolean;
 	readonly optionDelete?: boolean;
 	readonly optionRename?: boolean;
+	readonly optionMove?: boolean;
 }
 
 export interface ISelectPromptResult {
@@ -154,6 +156,14 @@ const RENAME_BUTTON: IQuickInputButton = Object.freeze({
 	iconClass: ThemeIcon.asClassName(Codicon.pencil),
 });
 
+/**
+ * Button that copies a prompt file.
+ */
+const COPY_BUTTON: IQuickInputButton = Object.freeze({
+	tooltip: localize('copy', "Copy"),
+	iconClass: ThemeIcon.asClassName(Codicon.copy),
+});
+
 export class PromptFilePickers {
 	constructor(
 		@ILabelService private readonly _labelService: ILabelService,
@@ -253,6 +263,9 @@ export class PromptFilePickers {
 		if (options.optionRename !== false) {
 			buttons.push(RENAME_BUTTON);
 		}
+		if (options.optionMove !== false) {
+			buttons.push(COPY_BUTTON);
+		}
 		if (options.optionDelete !== false) {
 			buttons.push(DELETE_BUTTON);
 		}
@@ -343,6 +356,17 @@ export class PromptFilePickers {
 		};
 	}
 
+	private async keepQuickPickOpen(quickPick: IQuickPick<IPromptPickerQuickPickItem>, work: () => Promise<void>): Promise<void> {
+		const previousIgnoreFocusOut = quickPick.ignoreFocusOut;
+		quickPick.ignoreFocusOut = true;
+		try {
+			await work();
+		} finally {
+			quickPick.ignoreFocusOut = previousIgnoreFocusOut;
+		}
+
+	}
+
 	private async _handleButtonClick(quickPick: IQuickPick<IPromptPickerQuickPickItem>, context: IQuickPickItemButtonEvent<IPromptPickerQuickPickItem>, options: ISelectOptions): Promise<void> {
 		const { item, button } = context;
 		const { value, } = item;
@@ -353,20 +377,32 @@ export class PromptFilePickers {
 			return;
 		}
 
+		// `copy` button was pressed, open the prompt file in editor
+		if (button === COPY_BUTTON) {
+			const currentFolder = dirname(value);
+			const newFolder = await this._instaService.invokeFunction(askForPromptSourceFolder, options.type, currentFolder);
+			if (!newFolder) {
+				return;
+			}
+			const newName = await this._instaService.invokeFunction(askForPromptFileName, options.type, newFolder.uri, item.label);
+			if (!newName) {
+				return;
+			}
+			const newFile = joinPath(newFolder.uri, newName);
+			await this._fileService.copy(value, newFile);
+			await this._openerService.open(newFile);
+
+			return;
+		}
+
 		// `rename` button was pressed, open a rename dialog
 		if (button === RENAME_BUTTON) {
-			// don't close the main prompt selection dialog by the confirmation dialog
-			const previousIgnoreFocusOut = quickPick.ignoreFocusOut;
-			quickPick.ignoreFocusOut = true;
-			try {
-				const currentFolder = dirname(value);
-				const newName = await this._instaService.invokeFunction(askForPromptFileName, options.type, currentFolder);
-				if (newName) {
-					await this._fileService.move(value, joinPath(currentFolder, newName));
-				}
-			} finally {
-				quickPick.ignoreFocusOut = previousIgnoreFocusOut;
-				quickPick.items = await this._createPromptPickItems(options);
+			const currentFolder = dirname(value);
+			const newName = await this._instaService.invokeFunction(askForPromptFileName, options.type, currentFolder, item.label);
+			if (newName) {
+				const newFile = joinPath(currentFolder, newName);
+				await this._fileService.move(value, newFile);
+				await this._openerService.open(newFile);
 			}
 			return;
 		}
@@ -389,56 +425,52 @@ export class PromptFilePickers {
 			);
 
 			// don't close the main prompt selection dialog by the confirmation dialog
-			const previousIgnoreFocusOut = quickPick.ignoreFocusOut;
-			quickPick.ignoreFocusOut = true;
-
-			const filename = getCleanPromptName(value);
-			const { confirmed } = await this._dialogService.confirm({
-				message: localize(
-					'commands.prompts.use.select-dialog.delete-prompt.confirm.message',
-					"Are you sure you want to delete '{0}'?",
-					filename,
-				),
-			});
-
-			// restore the previous value of the `ignoreFocusOut` property
-			quickPick.ignoreFocusOut = previousIgnoreFocusOut;
-
-			// if prompt deletion was not confirmed, nothing to do
-			if (!confirmed) {
-				return;
-			}
+			await this.keepQuickPickOpen(quickPick, async () => {
+
+				const filename = getCleanPromptName(value);
+				const { confirmed } = await this._dialogService.confirm({
+					message: localize(
+						'commands.prompts.use.select-dialog.delete-prompt.confirm.message',
+						"Are you sure you want to delete '{0}'?",
+						filename,
+					),
+				});
+
+				// if prompt deletion was not confirmed, nothing to do
+				if (!confirmed) {
+					return;
+				}
 
-			// prompt deletion was confirmed so delete the prompt file
-			await this._fileService.del(value);
+				// prompt deletion was confirmed so delete the prompt file
+				await this._fileService.del(value);
 
-			// remove the deleted prompt from the selection dialog list
-			let removedIndex = -1;
-			quickPick.items = quickPick.items.filter((option, index) => {
-				if (option === item) {
-					removedIndex = index;
+				// remove the deleted prompt from the selection dialog list
+				let removedIndex = -1;
+				quickPick.items = quickPick.items.filter((option, index) => {
+					if (option === item) {
+						removedIndex = index;
 
-					return false;
-				}
-
-				return true;
-			});
+						return false;
+					}
 
-			// if the deleted item was active item, find a new item to set as active
-			if (activeItem && (activeItem === item)) {
-				assert(
-					removedIndex >= 0,
-					'Removed item index must be a valid index.',
-				);
+					return true;
+				});
 
-				// we set the previous item as new active, or the next item
-				// if removed prompt item was in the beginning of the list
-				const newActiveItemIndex = Math.max(removedIndex - 1, 0);
-				const newActiveItem: IPromptPickerQuickPickItem | undefined = quickPick.items[newActiveItemIndex];
+				// if the deleted item was active item, find a new item to set as active
+				if (activeItem && (activeItem === item)) {
+					assert(
+						removedIndex >= 0,
+						'Removed item index must be a valid index.',
+					);
 
-				quickPick.activeItems = newActiveItem ? [newActiveItem] : [];
-			}
+					// we set the previous item as new active, or the next item
+					// if removed prompt item was in the beginning of the list
+					const newActiveItemIndex = Math.max(removedIndex - 1, 0);
+					const newActiveItem: IPromptPickerQuickPickItem | undefined = quickPick.items[newActiveItemIndex];
 
+					quickPick.activeItems = newActiveItem ? [newActiveItem] : [];
+				}
+			});
 			return;
 		}
 

src/vs/workbench/contrib/chat/browser/promptSyntax/contributions/createPromptCommand/dialogs/askForPromptSourceFolder.ts

@@ -6,7 +6,7 @@
 import { localize } from '../../../../../../../../nls.js';
 import { URI } from '../../../../../../../../base/common/uri.js';
 import { WithUriValue } from '../../../../../../../../base/common/types.js';
-import { basename, extUri } from '../../../../../../../../base/common/resources.js';
+import { basename, extUri, isEqual } from '../../../../../../../../base/common/resources.js';
 import { ILabelService } from '../../../../../../../../platform/label/common/label.js';
 import { IOpenerService } from '../../../../../../../../platform/opener/common/opener.js';
 import { PROMPT_DOCUMENTATION_URL } from '../../../../../common/promptSyntax/constants.js';
@@ -22,11 +22,11 @@ interface IFolderQuickPickItem extends IQuickPickItem {
 
 /**
  * Asks the user for a specific prompt folder, if multiple folders provided.
- * Returns immediately if only one folder available.
  */
 export async function askForPromptSourceFolder(
 	accessor: ServicesAccessor,
-	type: PromptsType
+	type: PromptsType,
+	existingFolder?: URI | undefined,
 ): Promise<IPromptPath | undefined> {
 	const quickInputService = accessor.get(IQuickInputService);
 	const promptsService = accessor.get(IPromptsService);
@@ -44,28 +44,29 @@ export async function askForPromptSourceFolder(
 		return;
 	}
 
-	// if there is only one folder, no need to ask
-	// note! when we add more actions to the dialog, this will have to go
-	if (folders.length === 1) {
+	// if there is only one folder and it's for new, no need to ask
+	if (!existingFolder && folders.length === 1) {
 		return folders[0];
 	}
 
 	const pickOptions: IPickOptions<IFolderQuickPickItem> = {
-		placeHolder: getPlaceholderString(type),
+		placeHolder: existingFolder ? getPlaceholderStringforMove(type) : getPlaceholderStringforNew(type),
 		canPickMany: false,
 		matchOnDescription: true,
 	};
 
 	// create list of source folder locations
 	const foldersList = folders.map<IFolderQuickPickItem>(folder => {
 		const uri = folder.uri;
+		const detail = (existingFolder && isEqual(uri, existingFolder)) ? localize('current.folder', "Current Location") : undefined;
 		if (folder.storage === 'user') {
 			return {
 				type: 'item',
 				label: localize(
 					'commands.prompts.create.source-folder.user',
 					"User Data Folder",
 				),
+				detail,
 				description: labelService.getUriLabel(uri),
 				tooltip: uri.fsPath,
 				folder
@@ -83,6 +84,7 @@ export async function askForPromptSourceFolder(
 			return {
 				type: 'item',
 				label: basename(uri),
+				detail,
 				description: labelService.getUriLabel(uri, { relative: true }),
 				tooltip: uri.fsPath,
 				folder,
@@ -97,6 +99,7 @@ export async function askForPromptSourceFolder(
 				'commands.prompts.create.source-folder.current-workspace',
 				"Current Workspace",
 			),
+			detail,
 			// use absolute path as the description
 			description: labelService.getUriLabel(uri, { relative: false }),
 			tooltip: uri.fsPath,
@@ -112,7 +115,7 @@ export async function askForPromptSourceFolder(
 	return answer.folder;
 }
 
-function getPlaceholderString(type: PromptsType): string {
+function getPlaceholderStringforNew(type: PromptsType): string {
 	switch (type) {
 		case PromptsType.instructions:
 			return localize('workbench.command.instructions.create.location.placeholder', "Select a location to create the instructions file in...");
@@ -125,6 +128,19 @@ function getPlaceholderString(type: PromptsType): string {
 	}
 }
 
+function getPlaceholderStringforMove(type: PromptsType): string {
+	switch (type) {
+		case PromptsType.instructions:
+			return localize('workbench.command.instructions.move.location.placeholder', "Select a location to move the instructions file to...");
+		case PromptsType.prompt:
+			return localize('workbench.command.prompt.move.location.placeholder', "Select a location to move the prompt file to...");
+		case PromptsType.mode:
+			return localize('workbench.command.mode.move.location.placeholder', "Select a location to move the mode file to...");
+		default:
+			throw new Error('Unknown prompt type');
+	}
+}
+
 /**
  * Shows a dialog to the user when no prompt source folders are found.
  *