Skip to content

Commit 03b15ac

Browse files
committed
fix vscode.resolveNotebookContentProviders command, microsoft#125757
1 parent bf99292 commit 03b15ac

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/vs/workbench/api/common/extHostTypeConverters.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { DisposableStore } from 'vs/base/common/lifecycle';
1010
import { marked } from 'vs/base/common/marked/marked';
1111
import { parse } from 'vs/base/common/marshalling';
1212
import { cloneAndChange } from 'vs/base/common/objects';
13-
import { isDefined, isEmptyObject, isNumber, isString, withNullAsUndefined } from 'vs/base/common/types';
13+
import { isDefined, isEmptyObject, isNumber, isString, isUndefinedOrNull, withNullAsUndefined } from 'vs/base/common/types';
1414
import { URI, UriComponents } from 'vs/base/common/uri';
1515
import { IURITransformer } from 'vs/base/common/uriIpc';
1616
import { RenderLineNumbersType } from 'vs/editor/common/config/editorOptions';
@@ -1665,8 +1665,7 @@ export namespace NotebookExclusiveDocumentPattern {
16651665
if (!ep) {
16661666
return false;
16671667
}
1668-
1669-
return !!ep.include && !!ep.exclude;
1668+
return !isUndefinedOrNull(ep.include) && !isUndefinedOrNull(ep.exclude);
16701669
}
16711670
}
16721671

src/vs/workbench/contrib/notebook/browser/controller/apiActions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { isDocumentExcludePattern, TransientCellMetadata, TransientDocumentMetad
1010
import { INotebookKernelService } from 'vs/workbench/contrib/notebook/common/notebookKernelService';
1111
import { INotebookService } from 'vs/workbench/contrib/notebook/common/notebookService';
1212

13-
CommandsRegistry.registerCommand('_resolveNotebookContentProvider', (accessor, args): {
13+
CommandsRegistry.registerCommand('_resolveNotebookContentProvider', (accessor): {
1414
viewType: string;
1515
displayName: string;
1616
options: { transientOutputs: boolean; transientCellMetadata: TransientCellMetadata; transientDocumentMetadata: TransientDocumentMetadata };

0 commit comments

Comments
 (0)