Skip to content

Commit 04d3b0f

Browse files
authored
Merge pull request microsoft#257510 from mjbvz/handsome-squirrel
Remove expandable hover setting
2 parents 8bef53d + 7094490 commit 04d3b0f

File tree

3 files changed

+1
-12
lines changed

3 files changed

+1
-12
lines changed

extensions/typescript-language-features/package.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -458,15 +458,6 @@
458458
"default": true,
459459
"markdownDescription": "%configuration.updateImportsOnPaste%"
460460
},
461-
"typescript.experimental.expandableHover": {
462-
"type": "boolean",
463-
"default": true,
464-
"description": "%configuration.expandableHover%",
465-
"scope": "window",
466-
"tags": [
467-
"experimental"
468-
]
469-
},
470461
"js/ts.hover.maximumLength": {
471462
"type": "number",
472463
"default": 500,

extensions/typescript-language-features/package.nls.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,6 @@
225225
"configuration.tsserver.web.typeAcquisition.enabled": "Enable/disable package acquisition on the web. This enables IntelliSense for imported packages. Requires `#typescript.tsserver.web.projectWideIntellisense.enabled#`. Currently not supported for Safari.",
226226
"configuration.tsserver.nodePath": "Run TS Server on a custom Node installation. This can be a path to a Node executable, or 'node' if you want VS Code to detect a Node installation.",
227227
"configuration.updateImportsOnPaste": "Automatically update imports when pasting code. Requires TypeScript 5.6+.",
228-
"configuration.expandableHover": "Enable expanding/contracting the hover to reveal more/less information from the TS server. Requires TypeScript 5.9+.",
229228
"configuration.hover.maximumLength": "The maximum number of characters in a hover. If the hover is longer than this, it will be truncated. Requires TypeScript 5.9+.",
230229
"walkthroughs.nodejsWelcome.title": "Get started with JavaScript and Node.js",
231230
"walkthroughs.nodejsWelcome.description": "Make the most of Visual Studio Code's first-class JavaScript experience.",

extensions/typescript-language-features/src/languageFeatures/hover.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,8 @@ class TypeScriptHoverProvider implements vscode.HoverProvider {
3333
return undefined;
3434
}
3535

36-
const enableExpandableHover = vscode.workspace.getConfiguration('typescript').get<boolean>('experimental.expandableHover', true);
3736
let verbosityLevel: number | undefined;
38-
if (enableExpandableHover && this.client.apiVersion.gte(API.v590)) {
37+
if (this.client.apiVersion.gte(API.v590)) {
3938
verbosityLevel = Math.max(0, this.getPreviousLevel(context?.previousHover) + (context?.verbosityDelta ?? 0));
4039
}
4140
const args = { ...typeConverters.Position.toFileLocationRequestArgs(filepath, position), verbosityLevel };

0 commit comments

Comments
 (0)