References view shows icons even though I have icons disabled (microsoft#151420)

Fixes microsoft#151406

Author: alexr00

src/vs/workbench/browser/parts/views/treeView.ts

@@ -64,7 +64,6 @@ import { Extensions, ITreeItem, ITreeItemLabel, ITreeView, ITreeViewDataProvider
 import { IActivityService, NumberBadge } from 'vs/workbench/services/activity/common/activity';
 import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions';
 import { IHoverService } from 'vs/workbench/services/hover/browser/hover';
-import { ThemeSettings } from 'vs/workbench/services/themes/common/workbenchThemeService';
 import { ITreeViewsService } from 'vs/workbench/services/views/browser/treeViewsService';
 import { CodeDataTransfers } from 'vs/platform/dnd/browser/dnd';
 import { createFileDataTransferItemFromFile } from 'vs/editor/browser/dnd';
@@ -1016,7 +1015,7 @@ class TreeRenderer extends Disposable implements ITreeRenderer<ITreeItem, FuzzyS
 			return ({ start, end });
 		}) : undefined;
 		const icon = this.themeService.getColorTheme().type === ColorScheme.LIGHT ? node.icon : node.iconDark;
-		const iconUrl = icon ? URI.revive(icon) : null;
+		const iconUrl = icon ? URI.revive(icon) : undefined;
 		const title = this.getHover(label, resource, node);
 
 		// reset
@@ -1029,7 +1028,7 @@ class TreeRenderer extends Disposable implements ITreeRenderer<ITreeItem, FuzzyS
 			templateData.resourceLabel.setResource({ name: label, description, resource: labelResource }, {
 				fileKind: this.getFileKind(node),
 				title,
-				hideIcon: !!iconUrl || this.shouldShowThemeIcon(!!resource, node.themeIcon),
+				hideIcon: this.shouldHideResourceLabelIcon(iconUrl, node.themeIcon),
 				fileDecorations,
 				extraClasses: ['custom-view-tree-node-item-resourceLabel'],
 				matches: matches ? matches : createMatches(element.filterData),
@@ -1050,8 +1049,6 @@ class TreeRenderer extends Disposable implements ITreeRenderer<ITreeItem, FuzzyS
 			templateData.icon.style.backgroundImage = DOM.asCSSUrl(iconUrl);
 		} else {
 			let iconClass: string | undefined;
-			// If there is a resource for this tree item then we should respect the file icon theme's choice about
-			// whether to show a folder icon.
 			if (this.shouldShowThemeIcon(!!resource, node.themeIcon)) {
 				iconClass = ThemeIcon.asClassName(node.themeIcon);
 				if (node.themeIcon.color) {
@@ -1084,25 +1081,20 @@ class TreeRenderer extends Disposable implements ITreeRenderer<ITreeItem, FuzzyS
 		container.parentElement!.classList.toggle('align-icon-with-twisty', this.aligner.alignIconWithTwisty(treeItem));
 	}
 
+	private shouldHideResourceLabelIcon(iconUrl: URI | undefined, icon: ThemeIcon | undefined): boolean {
+		// We always hide the resource label in favor of the iconUrl when it's provided.
+		// When `ThemeIcon` is provided, we hide the resource label icon in favor of it only if it's a not a file icon.
+		return !!iconUrl || !this.isFileKindThemeIcon(icon);
+	}
+
 	private shouldShowThemeIcon(hasResource: boolean, icon: ThemeIcon | undefined): icon is ThemeIcon {
 		if (!icon) {
 			return false;
 		}
 
-		if (hasResource && this.isFileKindThemeIcon(icon)) {
-			return !this.shouldShowFileIcons();
-		} else if (hasResource && this.isFolderThemeIcon(icon)) {
-			return !this.shouldShowFolderIcons();
-		}
-		return true;
-	}
-
-	private shouldShowFileIcons(): boolean {
-		return this.configurationService.getValue(ThemeSettings.FILE_ICON_THEME);
-	}
-
-	private shouldShowFolderIcons(): boolean {
-		return this.themeService.getFileIconTheme().hasFolderIcons && this.shouldShowFileIcons();
+		// If there's a resource and the icon is a file icon, then the icon (or lack thereof) will already be coming from the
+		// icon theme and should use whatever the icon theme has provided.
+		return !(hasResource && this.isFileKindThemeIcon(icon));
 	}
 
 	private isFolderThemeIcon(icon: ThemeIcon | undefined): boolean {