Skip to content

Commit 055f83c

Browse files
authored
Get correct container for inline chat overflow widgets (microsoft#235354)
Fixes microsoft#235353
1 parent c1d0d14 commit 055f83c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import { $, Dimension, getActiveElement, getTotalHeight, h, reset, trackFocus } from '../../../../base/browser/dom.js';
6+
import { $, Dimension, getActiveElement, getTotalHeight, getWindow, h, reset, trackFocus } from '../../../../base/browser/dom.js';
77
import { IActionViewItemOptions } from '../../../../base/browser/ui/actionbar/actionViewItems.js';
88
import { getDefaultHoverDelegate } from '../../../../base/browser/ui/hover/hoverDelegateFactory.js';
99
import { renderLabelWithIcons } from '../../../../base/browser/ui/iconLabel/iconLabels.js';
@@ -520,7 +520,7 @@ export class EditorBasedInlineChatWidget extends InlineChatWidget {
520520
@IHoverService hoverService: IHoverService,
521521
@ILayoutService layoutService: ILayoutService
522522
) {
523-
const overflowWidgetsNode = layoutService.mainContainer.appendChild($('.inline-chat-overflow.monaco-editor'));
523+
const overflowWidgetsNode = layoutService.getContainer(getWindow(_parentEditor.getContainerDomNode())).appendChild($('.inline-chat-overflow.monaco-editor'));
524524
super(location, {
525525
...options,
526526
chatWidgetViewOptions: {

src/vs/workbench/test/browser/workbenchTestServices.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ export class TestLayoutService implements IWorkbenchLayoutService {
642642
hasMainWindowBorder(): boolean { return false; }
643643
getMainWindowBorderRadius(): string | undefined { return undefined; }
644644
isVisible(_part: Parts): boolean { return true; }
645-
getContainer(): HTMLElement { return null!; }
645+
getContainer(): HTMLElement { return mainWindow.document.body; }
646646
whenContainerStylesLoaded() { return undefined; }
647647
isTitleBarHidden(): boolean { return false; }
648648
isStatusBarHidden(): boolean { return false; }

0 commit comments

Comments
 (0)