Skip to content

Commit 05b8f73

Browse files
author
Justin Chen
committed
minor fix on PR, pushing js/ts accidental to later PR
1 parent 2692ae4 commit 05b8f73

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/vs/editor/contrib/codeAction/browser/codeActionCommands.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ registerEditorCommand(new CodeActionContribution({
536536
kbOpts: {
537537
weight: weight + 100000,
538538
primary: KeyCode.UpArrow,
539-
secondary: [KeyMod.CtrlCmd | KeyCode.KeyK],
539+
secondary: [KeyMod.CtrlCmd | KeyCode.UpArrow],
540540
}
541541
}));
542542

@@ -549,7 +549,7 @@ registerEditorCommand(new CodeActionContribution({
549549
kbOpts: {
550550
weight: weight + 100000,
551551
primary: KeyCode.DownArrow,
552-
secondary: [KeyMod.CtrlCmd | KeyCode.KeyJ],
552+
secondary: [KeyMod.CtrlCmd | KeyCode.DownArrow],
553553
}
554554
}));
555555

src/vs/editor/contrib/codeAction/browser/codeActionMenu.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ export class CodeActionMenu extends Disposable implements IEditorContribution {
279279
this.codeActionList.value?.layout(height, maxWidth);
280280

281281
// List selection
282-
if (this.viewItems.length <= 1 && this.viewItems[0].title === 'Learn more about JS/TS refactorings') {
282+
if (this.viewItems.length < 1) {
283283
this.currSelectedItem = 0;
284284
} else {
285285
this.focusedEnabledItem = 0;
@@ -306,7 +306,7 @@ export class CodeActionMenu extends Disposable implements IEditorContribution {
306306
protected focusPrevious() {
307307
if (typeof this.focusedEnabledItem === 'undefined') {
308308
this.focusedEnabledItem = this.viewItems[0].index;
309-
} else if (this.viewItems.length <= 1 && this.viewItems[0].title !== 'Learn more about JS/TS refactorings') {
309+
} else if (this.viewItems.length < 1) {
310310
return false;
311311
}
312312

@@ -329,7 +329,7 @@ export class CodeActionMenu extends Disposable implements IEditorContribution {
329329
protected focusNext() {
330330
if (typeof this.focusedEnabledItem === 'undefined') {
331331
this.focusedEnabledItem = this.viewItems.length - 1;
332-
} else if (this.viewItems.length <= 1 && this.viewItems[0].title !== 'Learn more about JS/TS refactorings') {
332+
} else if (this.viewItems.length < 1) {
333333
return false;
334334
}
335335

0 commit comments

Comments
 (0)