Skip to content

Commit 06a0b22

Browse files
authored
tests: more complete stub for IExtHostTelemetry (microsoft#166709)
fixes microsoft#166432
1 parent d9df0ff commit 06a0b22

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/vs/workbench/api/test/browser/extHostApiCommands.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,11 @@ suite('ExtHostLanguageFeatureCommands', function () {
168168
const diagnostics = new ExtHostDiagnostics(rpcProtocol, new NullLogService(), new class extends mock<IExtHostFileSystemInfo>() { }, extHostDocumentsAndEditors);
169169
rpcProtocol.set(ExtHostContext.ExtHostDiagnostics, diagnostics);
170170

171-
extHost = new ExtHostLanguageFeatures(rpcProtocol, new URITransformerService(null), extHostDocuments, commands, diagnostics, new NullLogService(), NullApiDeprecationService, new class extends mock<IExtHostTelemetry>() { });
171+
extHost = new ExtHostLanguageFeatures(rpcProtocol, new URITransformerService(null), extHostDocuments, commands, diagnostics, new NullLogService(), NullApiDeprecationService, new class extends mock<IExtHostTelemetry>() {
172+
override onExtensionError(): boolean {
173+
return true;
174+
}
175+
});
172176
rpcProtocol.set(ExtHostContext.ExtHostLanguageFeatures, extHost);
173177

174178
mainThread = rpcProtocol.set(MainContext.MainThreadLanguageFeatures, insta.createInstance(MainThreadLanguageFeatures, rpcProtocol));

src/vs/workbench/api/test/browser/extHostLanguageFeatures.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,11 @@ suite('ExtHostLanguageFeatures', function () {
122122
const diagnostics = new ExtHostDiagnostics(rpcProtocol, new NullLogService(), new class extends mock<IExtHostFileSystemInfo>() { }, extHostDocumentsAndEditors);
123123
rpcProtocol.set(ExtHostContext.ExtHostDiagnostics, diagnostics);
124124

125-
extHost = new ExtHostLanguageFeatures(rpcProtocol, new URITransformerService(null), extHostDocuments, commands, diagnostics, new NullLogService(), NullApiDeprecationService, new class extends mock<IExtHostTelemetry>() { });
125+
extHost = new ExtHostLanguageFeatures(rpcProtocol, new URITransformerService(null), extHostDocuments, commands, diagnostics, new NullLogService(), NullApiDeprecationService, new class extends mock<IExtHostTelemetry>() {
126+
override onExtensionError(): boolean {
127+
return true;
128+
}
129+
});
126130
rpcProtocol.set(ExtHostContext.ExtHostLanguageFeatures, extHost);
127131

128132
mainThread = rpcProtocol.set(MainContext.MainThreadLanguageFeatures, inst.createInstance(MainThreadLanguageFeatures, rpcProtocol));

0 commit comments

Comments
 (0)