Don't contribute to statsBar when setting is off (microsoft#199592)

* various end game fixes

* added missing space

* better bool logic

* don't contribute problems when setting is off

* added problems visibility toggle to switch on

* fix merge conflic

* fix from PR comments, removing register

Author: justschen

src/vs/workbench/contrib/markers/browser/markers.contribution.ts

@@ -559,7 +559,7 @@ registerAction2(class extends Action2 {
 class MarkersStatusBarContributions extends Disposable implements IWorkbenchContribution {
 
 	private markersStatusItem: IStatusbarEntryAccessor;
-	private markersStatusItemOff: IStatusbarEntryAccessor;
+	private markersStatusItemOff: IStatusbarEntryAccessor | undefined;
 
 	constructor(
 		@IMarkerService private readonly markerService: IMarkerService,
@@ -568,15 +568,33 @@ class MarkersStatusBarContributions extends Disposable implements IWorkbenchCont
 	) {
 		super();
 		this.markersStatusItem = this._register(this.statusbarService.addEntry(this.getMarkersItem(), 'status.problems', StatusbarAlignment.LEFT, 50 /* Medium Priority */));
-		this.markersStatusItemOff = this._register(this.statusbarService.addEntry(this.getMarkersItemTurnedOff(), 'status.problemsVisibility', StatusbarAlignment.LEFT, 49));
+
+		const addStatusBarEntry = () => {
+			this.markersStatusItemOff = this.statusbarService.addEntry(this.getMarkersItemTurnedOff(), 'status.problemsVisibility', StatusbarAlignment.LEFT, 49);
+		};
+
+		// Add the status bar entry if the problems is not visible
+		let config = this.configurationService.getValue('problems.visibility');
+		if (!config) {
+			addStatusBarEntry();
+		}
+
 		this._register(this.markerService.onMarkerChanged(() => {
 			this.markersStatusItem.update(this.getMarkersItem());
-			this.markersStatusItemOff.update(this.getMarkersItemTurnedOff());
 		}));
+
 		this._register(this.configurationService.onDidChangeConfiguration(e => {
 			if (e.affectsConfiguration('problems.visibility')) {
 				this.markersStatusItem.update(this.getMarkersItem());
-				this.markersStatusItemOff.update(this.getMarkersItemTurnedOff());
+
+				// Update based on what setting was changed to.
+				config = this.configurationService.getValue('problems.visibility');
+				if (!config && !this.markersStatusItemOff) {
+					addStatusBarEntry();
+				} else if (config && this.markersStatusItemOff) {
+					this.markersStatusItemOff.dispose();
+					this.markersStatusItemOff = undefined;
+				}
 			}
 		}));
 	}
@@ -594,12 +612,11 @@ class MarkersStatusBarContributions extends Disposable implements IWorkbenchCont
 	}
 
 	private getMarkersItemTurnedOff(): IStatusbarEntry {
-		const config = this.configurationService.getValue('problems.visibility');
-		this.statusbarService.updateEntryVisibility('status.problemsVisibility', !config);
-
+		// Update to true, config checked before `getMarkersItemTurnedOff` is called.
+		this.statusbarService.updateEntryVisibility('status.problemsVisibility', true);
 		const openSettingsCommand = 'workbench.action.openSettings';
 		const configureSettingsLabel = '@id:problems.visibility';
-		const tooltip = !config ? localize('problemsOff', "Problems have been turned off.") : '';
+		const tooltip = localize('status.problemsVisibilityOff', "Problems are turned off. Click to open settings.");
 		return {
 			name: localize('status.problemsVisibility', "Problems Visibility"),
 			text: '$(whole-word)',