Add chat setup view for all users out of the box to secondary sidebar (fix microsoft/vscode-copilot#11195)

Author: bpasero

src/vs/workbench/contrib/chat/browser/chatParticipant.contribution.ts

@@ -312,7 +312,7 @@ export class ChatExtensionPointHandler implements IWorkbenchContribution {
 			},
 			ctorDescriptor: new SyncDescriptor(ChatViewPane, [{ location: ChatAgentLocation.Panel }]),
 			when: ContextKeyExpr.or(
-				ChatContextKeys.Setup.triggered,
+				ChatContextKeys.Setup.hidden.negate(),
 				ChatContextKeys.Setup.installed,
 				ChatContextKeys.panelParticipantRegistered,
 				ChatContextKeys.extensionInvalid

src/vs/workbench/contrib/chat/browser/chatSetup.ts

@@ -169,7 +169,7 @@ export class ChatSetupContribution extends Disposable implements IWorkbenchContr
 				const configurationService = accessor.get(IConfigurationService);
 				const layoutService = accessor.get(IWorkbenchLayoutService);
 
-				await that.context.update({ triggered: true });
+				await that.context.update({ hidden: false });
 
 				showCopilotView(viewsService, layoutService);
 				ensureSideBarChatViewSize(400, viewDescriptorService, layoutService);
@@ -282,7 +282,7 @@ export class ChatSetupContribution extends Disposable implements IWorkbenchContr
 		async function hideSetupView(viewsDescriptorService: IViewDescriptorService, layoutService: IWorkbenchLayoutService): Promise<void> {
 			const location = viewsDescriptorService.getViewLocationById(ChatViewId);
 
-			await that.context.update({ triggered: false });
+			await that.context.update({ hidden: true });
 
 			if (location === ViewContainerLocation.AuxiliaryBar) {
 				const activeContainers = viewsDescriptorService.getViewContainersByLocation(location).filter(container => viewsDescriptorService.getViewContainerModel(container).activeViewDescriptors.length > 0);
@@ -1020,7 +1020,7 @@ class ChatSetupWelcomeContent extends Disposable {
 
 interface IChatSetupContextState {
 	entitlement: ChatEntitlement;
-	triggered?: boolean;
+	hidden?: boolean;
 	installed?: boolean;
 	registered?: boolean;
 }
@@ -1033,7 +1033,7 @@ class ChatSetupContext extends Disposable {
 	private readonly signedOutContextKey = ChatContextKeys.Setup.signedOut.bindTo(this.contextKeyService);
 	private readonly limitedContextKey = ChatContextKeys.Setup.limited.bindTo(this.contextKeyService);
 	private readonly proContextKey = ChatContextKeys.Setup.pro.bindTo(this.contextKeyService);
-	private readonly triggeredContext = ChatContextKeys.Setup.triggered.bindTo(this.contextKeyService);
+	private readonly hiddenContext = ChatContextKeys.Setup.hidden.bindTo(this.contextKeyService);
 	private readonly installedContext = ChatContextKeys.Setup.installed.bindTo(this.contextKeyService);
 
 	private _state: IChatSetupContextState = this.storageService.getObject<IChatSetupContextState>(ChatSetupContext.CHAT_SETUP_CONTEXT_STORAGE_KEY, StorageScope.PROFILE) ?? { entitlement: ChatEntitlement.Unknown };
@@ -1078,21 +1078,21 @@ class ChatSetupContext extends Disposable {
 	}
 
 	update(context: { installed: boolean }): Promise<void>;
-	update(context: { triggered: boolean }): Promise<void>;
+	update(context: { hidden: boolean }): Promise<void>;
 	update(context: { entitlement: ChatEntitlement }): Promise<void>;
-	update(context: { installed?: boolean; triggered?: boolean; entitlement?: ChatEntitlement }): Promise<void> {
+	update(context: { installed?: boolean; hidden?: boolean; entitlement?: ChatEntitlement }): Promise<void> {
 		this.logService.trace(`[chat setup] update(): ${JSON.stringify(context)}`);
 
 		if (typeof context.installed === 'boolean') {
 			this._state.installed = context.installed;
 
 			if (context.installed) {
-				context.triggered = true; // allows to fallback to setup view if the extension is uninstalled
+				context.hidden = false; // allows to fallback to setup view if the extension is uninstalled
 			}
 		}
 
-		if (typeof context.triggered === 'boolean') {
-			this._state.triggered = context.triggered;
+		if (typeof context.hidden === 'boolean') {
+			this._state.hidden = context.hidden;
 		}
 
 		if (typeof context.entitlement === 'number') {
@@ -1119,7 +1119,7 @@ class ChatSetupContext extends Disposable {
 	private updateContextSync(): void {
 		this.logService.trace(`[chat setup] updateContext(): ${JSON.stringify(this._state)}`);
 
-		if (this._state.triggered && !this._state.installed) {
+		if (!this._state.hidden && !this._state.installed) {
 			// this is ugly but fixes flicker from a previous chat install
 			this.storageService.remove('chat.welcomeMessageContent.panel', StorageScope.APPLICATION);
 			this.storageService.remove('interactive.sessions', this.workspaceContextService.getWorkspace().folders.length ? StorageScope.WORKSPACE : StorageScope.APPLICATION);
@@ -1129,7 +1129,7 @@ class ChatSetupContext extends Disposable {
 		this.canSignUpContextKey.set(this._state.entitlement === ChatEntitlement.Available);
 		this.limitedContextKey.set(this._state.entitlement === ChatEntitlement.Limited);
 		this.proContextKey.set(this._state.entitlement === ChatEntitlement.Pro);
-		this.triggeredContext.set(!!this._state.triggered);
+		this.hiddenContext.set(!!this._state.hidden);
 		this.installedContext.set(!!this._state.installed);
 
 		this._onDidChange.fire();

src/vs/workbench/contrib/chat/common/chatContextKeys.ts

@@ -51,7 +51,7 @@ export namespace ChatContextKeys {
 
 		// State
 		signedOut: new RawContextKey<boolean>('chatSetupSignedOut', false, true), 	// True when user is signed out.
-		triggered: new RawContextKey<boolean>('chatSetupTriggered', false, true), 	// True when chat setup is triggered.
+		hidden: new RawContextKey<boolean>('chatSetupHidden', false, true), 		// True when chat setup is explicitly hidden.
 		installed: new RawContextKey<boolean>('chatSetupInstalled', false, true),  	// True when the chat extension is installed.
 
 		// Plans
@@ -60,10 +60,10 @@ export namespace ChatContextKeys {
 		pro: new RawContextKey<boolean>('chatPlanPro', false, true) 				// True when user is a chat pro user.
 	};
 
-	export const SetupViewKeys = new Set([ChatContextKeys.Setup.triggered.key, ChatContextKeys.Setup.installed.key, ChatContextKeys.Setup.signedOut.key, ChatContextKeys.Setup.canSignUp.key]);
+	export const SetupViewKeys = new Set([ChatContextKeys.Setup.hidden.key, ChatContextKeys.Setup.installed.key, ChatContextKeys.Setup.signedOut.key, ChatContextKeys.Setup.canSignUp.key]);
 	export const SetupViewCondition = ContextKeyExpr.or(
 		ContextKeyExpr.and(
-			ChatContextKeys.Setup.triggered,
+			ChatContextKeys.Setup.hidden.negate(),
 			ChatContextKeys.Setup.installed.negate()
 		),
 		ContextKeyExpr.and(