Fix leaks in notebook diffing (microsoft#242385)

DonJayamanne · web-flow · commit 0ae8e420ca64 · 2025-03-01T14:28:29.000+01:00
diff --git a/src/vs/workbench/contrib/notebook/browser/services/notebookWorkerServiceImpl.ts b/src/vs/workbench/contrib/notebook/browser/services/notebookWorkerServiceImpl.ts
@@ -65,6 +65,7 @@ class WorkerManager extends Disposable {
 		// this._lastWorkerUsedTime = (new Date()).getTime();
 		if (!this._editorWorkerClient) {
 			this._editorWorkerClient = new NotebookWorkerClient(this._notebookService, this._modelService);
+			this._register(this._editorWorkerClient);
 		}
 		return Promise.resolve(this._editorWorkerClient);
 	}

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ class WorkerManager extends Disposable {`
`65`	`65`	`// this._lastWorkerUsedTime = (new Date()).getTime();`
`66`	`66`	`if (!this._editorWorkerClient) {`
`67`	`67`	`this._editorWorkerClient = new NotebookWorkerClient(this._notebookService, this._modelService);`
	`68`	`+ this._register(this._editorWorkerClient);`
`68`	`69`	`}`
`69`	`70`	`return Promise.resolve(this._editorWorkerClient);`
`70`	`71`	`}`