removing the position from the resizable content widget and adding it into the content hover

Author: aiday-mar

src/vs/editor/contrib/hover/browser/contentHover.ts

@@ -453,6 +453,7 @@ export class ContentHoverWidget extends ResizableContentWidget {
 	private _disposableStore = new DisposableStore();
 	private _visibleData: ContentHoverVisibleData | undefined;
 	private _positionPreference: ContentWidgetPositionPreference | undefined;
+	private _position: Position | undefined;
 
 	private readonly _hover: HoverWidget = this._disposableStore.add(new HoverWidget());
 	private readonly _hoverVisibleKey: IContextKey<boolean>;
@@ -470,6 +471,14 @@ export class ContentHoverWidget extends ResizableContentWidget {
 		return this._hoverVisibleKey.get() ?? false;
 	}
 
+	get position(): Position | undefined {
+		return this._position;
+	}
+
+	set position(position: Position | undefined) {
+		this._position = position;
+	}
+
 	constructor(
 		_editor: ICodeEditor,
 		@IContextKeyService _contextKeyService: IContextKeyService
@@ -635,12 +644,8 @@ export class ContentHoverWidget extends ResizableContentWidget {
 		return true;
 	}
 
-	private _setWidgetPosition(position: Position | undefined) {
-		this._position = position;
-	}
-
 	private _setHoverData(hoverData: ContentHoverVisibleData | undefined): void {
-		this._setWidgetPosition(hoverData?.showAtPosition);
+		this._position = hoverData?.showAtPosition;
 		this._visibleData?.disposables.dispose();
 		this._visibleData = hoverData;
 		this._hoverVisibleKey.set(!!hoverData);

src/vs/editor/contrib/hover/browser/resizableContentWidget.ts

@@ -8,7 +8,7 @@ import { Disposable } from 'vs/base/common/lifecycle';
 import { ContentWidgetPositionPreference, ICodeEditor, IContentWidget, IContentWidgetPosition } from 'vs/editor/browser/editorBrowser';
 import { EditorOption } from 'vs/editor/common/config/editorOptions';
 import { clamp } from 'vs/base/common/numbers';
-import { IPosition, Position } from 'vs/editor/common/core/position';
+import { IPosition } from 'vs/editor/common/core/position';
 import * as dom from 'vs/base/browser/dom';
 
 const HEADER_HEIGHT = 30;
@@ -21,7 +21,6 @@ export abstract class ResizableContentWidget extends Disposable implements ICont
 
 	protected readonly _resizableNode = this._register(new ResizableHTMLElement());
 	protected _contentPosition: IContentWidgetPosition | null = null;
-	protected _position: Position | undefined;
 
 	private _isResizing: boolean = false;
 
@@ -59,14 +58,6 @@ export abstract class ResizableContentWidget extends Disposable implements ICont
 		return this._contentPosition;
 	}
 
-	get position(): Position | undefined {
-		return this._position;
-	}
-
-	set position(position: Position | undefined) {
-		this._position = position;
-	}
-
 	protected _availableVerticalSpaceAbove(position: IPosition): number | undefined {
 		const editorDomNode = this._editor.getDomNode();
 		const mouseBox = this._editor.getScrolledVisiblePosition(position);