limit error notifications in macos update service (microsoft#182269)

joaomoreno · web-flow · commit 0ca6d0fb1ddb · 2023-05-12T09:57:32.000+02:00
fixes microsoft#182250
diff --git a/src/vs/platform/update/electron-main/updateService.darwin.ts b/src/vs/platform/update/electron-main/updateService.darwin.ts
@@ -50,8 +50,7 @@ export class DarwinUpdateService extends AbstractUpdateService {
 		this.logService.error('UpdateService error:', err);
 
 		// only show message when explicitly checking for updates
-		const shouldShowMessage = this.state.type === StateType.CheckingForUpdates ? this.state.explicit : true;
-		const message: string | undefined = shouldShowMessage ? err : undefined;
+		const message = (this.state.type === StateType.CheckingForUpdates && this.state.explicit) ? err : undefined;
 		this.setState(State.Idle(UpdateType.Archive, message));
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,7 @@ export class DarwinUpdateService extends AbstractUpdateService {`
`50`	`50`	`this.logService.error('UpdateService error:', err);`
`51`	`51`
`52`	`52`	`// only show message when explicitly checking for updates`
`53`		`- const shouldShowMessage = this.state.type === StateType.CheckingForUpdates ? this.state.explicit : true;`
`54`		`- const message: string \| undefined = shouldShowMessage ? err : undefined;`
	`53`	`+ const message = (this.state.type === StateType.CheckingForUpdates && this.state.explicit) ? err : undefined;`
`55`	`54`	`this.setState(State.Idle(UpdateType.Archive, message));`
`56`	`55`	`}`
`57`	`56`