Skip to content

Commit 0cf685c

Browse files
authored
Remove unneeded check for disposed terminal (microsoft#184190)
Since microsoft#180018 is fixed
1 parent 8bac540 commit 0cf685c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/vs/workbench/contrib/chat/browser/actions/chatCodeblockActions.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -336,9 +336,8 @@ export function registerChatCodeBlockActions() {
336336

337337
let terminal = await terminalService.getActiveOrCreateInstance();
338338

339-
// Why does getActiveOrCreateInstance return a disposed terminal? #180018
340-
// isFeatureTerminal = debug terminal
341-
const unusableTerminal = terminal.isDisposed || terminal.xterm?.isStdinDisabled || terminal.shellLaunchConfig.isFeatureTerminal;
339+
// isFeatureTerminal = debug terminal or task terminal
340+
const unusableTerminal = terminal.xterm?.isStdinDisabled || terminal.shellLaunchConfig.isFeatureTerminal;
342341
terminal = unusableTerminal ? await terminalService.createTerminal() : terminal;
343342

344343
terminalService.setActiveInstance(terminal);

0 commit comments

Comments
 (0)