fix: terminal suggestions should hide modal when no completions exist

Signed-off-by: Chapman Pendery <[email protected]>

Author: cpendery

src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts

@@ -452,7 +452,7 @@ export class SuggestAddon extends Disposable implements ITerminalAddon, ISuggest
 			}
 
 			// Hide and clear model if there are no more items
-			if ((this._suggestWidget as any)._completionModel?.items.length === 0) {
+			if (!this._suggestWidget?.hasCompletions()) {
 				this._additionalInput = undefined;
 				this.hideSuggestWidget();
 				// TODO: Don't request every time; refine completions

src/vs/workbench/services/suggest/browser/simpleSuggestWidget.ts

@@ -208,6 +208,10 @@ export class SimpleSuggestWidget implements IDisposable {
 		this._completionModel = completionModel;
 	}
 
+	hasCompletions(): boolean {
+		return this._completionModel?.items.length !== 0;
+	}
+
 	showSuggestions(selectionIndex: number, isFrozen: boolean, isAuto: boolean, cursorPosition: { top: number; left: number; height: number }): void {
 		this._cursorPosition = cursorPosition;