Use readonly editor instead of an untitled buffer when showing environment changes

Author: Kartik Raj

src/vs/workbench/contrib/terminalContrib/environmentChanges/browser/terminal.environmentChanges.contribution.ts

@@ -3,9 +3,13 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { Schemas } from 'vs/base/common/network';
 import { URI } from 'vs/base/common/uri';
+import { Event } from 'vs/base/common/event';
+import { ITextModel } from 'vs/editor/common/model';
+import { IModelService } from 'vs/editor/common/services/model';
+import { ITextModelContentProvider, ITextModelService } from 'vs/editor/common/services/resolverService';
 import { localize } from 'vs/nls';
+import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
 import { EnvironmentVariableMutatorType, EnvironmentVariableScope, IEnvironmentVariableMutator, IMergedEnvironmentVariableCollection } from 'vs/platform/terminal/common/environmentVariable';
 import { registerActiveInstanceAction } from 'vs/workbench/contrib/terminal/browser/terminalActions';
 import { TerminalCommandId } from 'vs/workbench/contrib/terminal/common/terminal';
@@ -16,17 +20,27 @@ import { IEditorService } from 'vs/workbench/services/editor/common/editorServic
 registerActiveInstanceAction({
 	id: TerminalCommandId.ShowEnvironmentContributions,
 	title: { value: localize('workbench.action.terminal.showEnvironmentContributions', "Show Environment Contributions"), original: 'Show Environment Contributions' },
-	run: async (activeInstance, c, accessor, scope) => {
+	run: async (activeInstance, c, accessor, arg) => {
 		const collection = activeInstance.extEnvironmentVariableCollection;
 		if (collection) {
+			const scope = arg as EnvironmentVariableScope | undefined;
+			const instantiationService = accessor.get(IInstantiationService);
+			const outputProvider = instantiationService.createInstance(EnvironmentCollectionProvider);
 			const editorService = accessor.get(IEditorService);
-			await editorService.openEditor({
-				resource: URI.from({
-					scheme: Schemas.untitled
-				}),
-				contents: describeEnvironmentChanges(collection, scope as EnvironmentVariableScope | undefined),
-				languageId: 'markdown'
-			});
+			const timestamp = new Date().getTime();
+			const scopeDesc = scope?.workspaceFolder ? ` - ${scope.workspaceFolder.name}` : '';
+			const textContent = await outputProvider.provideTextContent(URI.from(
+				{
+					scheme: EnvironmentCollectionProvider.scheme,
+					path: `Environment changes${scopeDesc}`,
+					fragment: describeEnvironmentChanges(collection, scope),
+					query: `environment-collection-${timestamp}`
+				}));
+			if (textContent) {
+				await editorService.openEditor({
+					resource: textContent.uri
+				});
+			}
 		}
 	}
 });
@@ -68,3 +82,23 @@ function mutatorTypeLabel(type: EnvironmentVariableMutatorType, value: string, v
 		default: return `${variable}=${value}`;
 	}
 }
+
+class EnvironmentCollectionProvider implements ITextModelContentProvider {
+	static scheme = 'ENVIRONMENT_CHANGES_COLLECTION';
+
+	constructor(
+		@ITextModelService textModelResolverService: ITextModelService,
+		@IModelService private readonly _modelService: IModelService
+	) {
+		textModelResolverService.registerTextModelContentProvider(EnvironmentCollectionProvider.scheme, this);
+	}
+
+	async provideTextContent(resource: URI): Promise<ITextModel | null> {
+		const existing = this._modelService.getModel(resource);
+		if (existing && !existing.isDisposed()) {
+			return existing;
+		}
+
+		return this._modelService.createModel(resource.fragment, { languageId: 'markdown', onDidChange: Event.None }, resource, false);
+	}
+}