debt - remove _isFakeAction again (microsoft#164240)

Author: jrieken

src/vs/platform/action/common/action.ts

@@ -72,9 +72,6 @@ export interface ICommandAction {
 	 * or define toggle-info including an icon and a title that goes well with a checkmark.
 	 */
 	toggled?: ContextKeyExpression | ICommandActionToggleInfo;
-
-	/** @deprecated see https://github.com/microsoft/vscode/issues/162004 */
-	_isFakeAction?: true;
 }
 
 export type ISerializableCommandAction = UriDto<ICommandAction>;

src/vs/platform/actions/common/actions.ts

@@ -556,13 +556,6 @@ interface IAction2CommonOptions extends ICommandAction {
 	 * showing keybindings that have no other UX.
 	 */
 	description?: ICommandHandlerDescription;
-
-	/**
-	 * @deprecated workaround added for https://github.com/microsoft/vscode/issues/162004
-	 * This action doesn't do anything is just a workaround for rendering "something"
-	 * inside a specific toolbar
-	 */
-	_isFakeAction?: true;
 }
 
 interface IBaseAction2Options extends IAction2CommonOptions {

src/vs/platform/actions/common/menuService.ts

@@ -228,8 +228,7 @@ class MenuInfo {
 					const menuHide = createMenuHide(this._id, isMenuItem ? item.command : item, this._hiddenStates);
 					if (isMenuItem) {
 						// MenuItemAction
-						const actualMenuHide = item.command._isFakeAction ? undefined : menuHide;
-						activeActions.push(new MenuItemAction(item.command, item.alt, options, actualMenuHide, this._contextKeyService, this._commandService));
+						activeActions.push(new MenuItemAction(item.command, item.alt, options, menuHide, this._contextKeyService, this._commandService));
 
 					} else {
 						// SubmenuItemAction