Merge pull request microsoft#188476 from microsoft/joh/occupational-vulture

jrieken · web-flow · commit 110e2f633cb2 · 2023-07-21T13:50:29.000+02:00
Improve message of performance error
diff --git a/src/vs/platform/profiling/common/profilingTelemetrySpec.ts b/src/vs/platform/profiling/common/profilingTelemetrySpec.ts
@@ -67,11 +67,11 @@ class PerformanceError extends Error {
 	readonly selfTime: number;
 
 	constructor(data: SampleData) {
-		super('[PerfSampleError]');
+		super(`PerfSampleError: by ${data.source} in ${data.sample.location}`);
 		this.name = 'PerfSampleError';
 		this.selfTime = data.sample.selfTime;
 
 		const trace = [data.sample.absLocation, ...data.sample.caller.map(c => c.absLocation)];
-		this.stack = `${this.message} by ${data.source} in ${data.sample.location}\n\t at ${trace.join('\n\t at ')}`;
+		this.stack = `\n\t at ${trace.join('\n\t at ')}`;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -67,11 +67,11 @@ class PerformanceError extends Error {`
`67`	`67`	`readonly selfTime: number;`
`68`	`68`
`69`	`69`	`constructor(data: SampleData) {`
`70`		`- super('[PerfSampleError]');`
	`70`	+ super(`PerfSampleError: by ${data.source} in ${data.sample.location}`);
`71`	`71`	`this.name = 'PerfSampleError';`
`72`	`72`	`this.selfTime = data.sample.selfTime;`
`73`	`73`
`74`	`74`	`const trace = [data.sample.absLocation, ...data.sample.caller.map(c => c.absLocation)];`
`75`		- this.stack = `${this.message} by ${data.source} in ${data.sample.location}\n\t at ${trace.join('\n\t at ')}`;
	`75`	+ this.stack = `\n\t at ${trace.join('\n\t at ')}`;
`76`	`76`	`}`
`77`	`77`	`}`