Skip to content

Commit 12d2660

Browse files
authored
Refactor sash hover border to use CSS var (microsoft#165516)
Ref microsoft#165169
1 parent 0bc4682 commit 12d2660

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

src/vs/base/browser/ui/sash/sash.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,11 @@
111111
background: transparent;
112112
}
113113

114+
.monaco-sash.hover:before,
115+
.monaco-sash.active:before {
116+
background: var(--vscode-sash-hoverBorder);
117+
}
118+
114119
.monaco-sash.vertical:before {
115120
width: var(--sash-hover-size);
116121
left: calc(50% - (var(--sash-hover-size) / 2));

src/vs/workbench/contrib/sash/browser/sash.contribution.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ import { Registry } from 'vs/platform/registry/common/platform';
1010
import { workbenchConfigurationNodeBase } from 'vs/workbench/common/configuration';
1111
import { IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions } from 'vs/workbench/common/contributions';
1212
import { SashSettingsController } from 'vs/workbench/contrib/sash/browser/sash';
13-
import { registerThemingParticipant } from 'vs/platform/theme/common/themeService';
14-
import { sashHoverBorder } from 'vs/platform/theme/common/colorRegistry';
1513
import { isIOS } from 'vs/base/common/platform';
1614

1715
// Sash size contribution
@@ -39,13 +37,3 @@ Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration)
3937
},
4038
}
4139
});
42-
43-
registerThemingParticipant((theme, collector) => {
44-
const sashHoverBorderColor = theme.getColor(sashHoverBorder);
45-
collector.addRule(`
46-
.monaco-sash.hover:before,
47-
.monaco-sash.active:before {
48-
background: ${sashHoverBorderColor};
49-
}
50-
`);
51-
});

0 commit comments

Comments
 (0)