Skip to content

Commit 12d38b2

Browse files
authored
Prefer non-builtin output renderers in notebooks (microsoft#136079)
Fixes microsoft#134172 This change updates `findBestRenderers` to sort non built-in renderers higher than built-in ones
1 parent a84f6fe commit 12d38b2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/vs/workbench/contrib/notebook/browser/notebookServiceImpl.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -314,8 +314,8 @@ export class NotebookOutputRendererInfoStore {
314314
const enum ReuseOrder {
315315
PreviouslySelected = 1 << 8,
316316
SameExtensionAsNotebook = 2 << 8,
317-
BuiltIn = 3 << 8,
318-
OtherRenderer = 4 << 8
317+
OtherRenderer = 3 << 8,
318+
BuiltIn = 4 << 8,
319319
}
320320

321321
const preferred = notebookProviderInfo && this.preferredMimetype.getValue()[notebookProviderInfo.id]?.[mimeType];
@@ -333,7 +333,7 @@ export class NotebookOutputRendererInfoStore {
333333
? ReuseOrder.PreviouslySelected
334334
: renderer.extensionId.value === notebookProviderInfo?.extension?.value
335335
? ReuseOrder.SameExtensionAsNotebook
336-
: ReuseOrder.BuiltIn;
336+
: renderer.isBuiltin ? ReuseOrder.BuiltIn : ReuseOrder.OtherRenderer;
337337
return {
338338
ordered: { mimeType, rendererId: renderer.id, isTrusted: true },
339339
score: reuseScore | ownScore,

0 commit comments

Comments
 (0)