fix: don't register Cloud Changes action if not configured in product.json (microsoft#236764)

joyceerhl · web-flow · commit 13d2a615cb98 · 2024-12-20T14:33:52.000-08:00
diff --git a/src/vs/workbench/contrib/editSessions/browser/editSessionsStorageService.ts b/src/vs/workbench/contrib/editSessions/browser/editSessionsStorageService.ts
@@ -455,6 +455,9 @@ export class EditSessionsWorkbenchService extends Disposable implements IEditSes
 	}
 
 	private registerSignInAction() {
+		if (!this.serverConfiguration?.url) {
+			return;
+		}
 		const that = this;
 		const id = 'workbench.editSessions.actions.signIn';
 		const when = ContextKeyExpr.and(ContextKeyExpr.equals(EDIT_SESSIONS_PENDING_KEY, false), ContextKeyExpr.equals(EDIT_SESSIONS_SIGNED_IN_KEY, false));

Original file line number	Diff line number	Diff line change
`@@ -455,6 +455,9 @@ export class EditSessionsWorkbenchService extends Disposable implements IEditSes`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`private registerSignInAction() {`
	`458`	`+ if (!this.serverConfiguration?.url) {`
	`459`	`+ return;`
	`460`	`+ }`
`458`	`461`	`const that = this;`
`459`	`462`	`const id = 'workbench.editSessions.actions.signIn';`
`460`	`463`	`const when = ContextKeyExpr.and(ContextKeyExpr.equals(EDIT_SESSIONS_PENDING_KEY, false), ContextKeyExpr.equals(EDIT_SESSIONS_SIGNED_IN_KEY, false));`