Merge pull request microsoft#186732 from microsoft/tyriar/133542_log_error

Tyriar · web-flow · commit 14971879ebdb · 2023-06-30T06:25:57.000-07:00
Log errors in getTerminalLayoutInfo
diff --git a/src/vs/workbench/contrib/terminal/electron-sandbox/localTerminalBackend.ts b/src/vs/workbench/contrib/terminal/electron-sandbox/localTerminalBackend.ts
@@ -298,8 +298,8 @@ class LocalTerminalBackend extends BaseTerminalBackend implements ITerminalBacke
 					mark('code/terminal/didSetTerminalLayoutInfo');
 					this._storageService.remove(TerminalStorageKeys.TerminalLayoutInfo, StorageScope.WORKSPACE);
 				}
-			} catch {
-				// no-op
+			} catch (e: unknown) {
+				this._logService.warn('LocalTerminalBackend#getTerminalLayoutInfo Error', e && typeof e === 'object' && 'message' in e ? e.message : e);
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -298,8 +298,8 @@ class LocalTerminalBackend extends BaseTerminalBackend implements ITerminalBacke`
`298`	`298`	`mark('code/terminal/didSetTerminalLayoutInfo');`
`299`	`299`	`this._storageService.remove(TerminalStorageKeys.TerminalLayoutInfo, StorageScope.WORKSPACE);`
`300`	`300`	`}`
`301`		`- } catch {`
`302`		`- // no-op`
	`301`	`+ } catch (e: unknown) {`
	`302`	`+ this._logService.warn('LocalTerminalBackend#getTerminalLayoutInfo Error', e && typeof e === 'object' && 'message' in e ? e.message : e);`
`303`	`303`	`}`
`304`	`304`	`}`
`305`	`305`