Merge pull request microsoft#146735 from microsoft/aeschli/fix-146607

aeschli · web-flow · commit 14d3a4bbf11a · 2022-04-04T18:06:58.000+02:00
Fix unnecessary 'semicolon expected' errors
diff --git a/extensions/html-language-features/server/src/modes/embeddedSupport.ts b/extensions/html-language-features/server/src/modes/embeddedSupport.ts
@@ -181,7 +181,6 @@ function getPrefix(c: EmbeddedRegion) {
 	if (c.attributeValue) {
 		switch (c.languageId) {
 			case 'css': return CSS_STYLE_RULE + '{';
-			case 'javascript': return '()=>{';
 		}
 	}
 	return '';
@@ -190,7 +189,7 @@ function getSuffix(c: EmbeddedRegion) {
 	if (c.attributeValue) {
 		switch (c.languageId) {
 			case 'css': return '}';
-			case 'javascript': return '};';
+			case 'javascript': return ';';
 		}
 	}
 	return '';
diff --git a/extensions/html-language-features/server/src/test/embedded.test.ts b/extensions/html-language-features/server/src/test/embedded.test.ts
@@ -120,7 +120,7 @@ suite('HTML Embedded Support', () => {
 		assertEmbeddedLanguageContent('<html><script>var i = 0;</script></html>', 'javascript', '              var i = 0;                ');
 		assertEmbeddedLanguageContent('<script type="text/javascript">var i = 0;</script>', 'javascript', '                               var i = 0;         ');
 
-		assertEmbeddedLanguageContent('<div onKeyUp="foo()" onkeydown="bar()"/>', 'javascript', '         ()=>{foo()};      ()=>{bar()}; ');
+		assertEmbeddedLanguageContent('<div onKeyUp="foo()" onkeydown="bar()"/>', 'javascript', '              foo();            bar();  ');
 	});
 
 });

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,6 @@ function getPrefix(c: EmbeddedRegion) {`
`181`	`181`	`if (c.attributeValue) {`
`182`	`182`	`switch (c.languageId) {`
`183`	`183`	`case 'css': return CSS_STYLE_RULE + '{';`
`184`		`- case 'javascript': return '()=>{';`
`185`	`184`	`}`
`186`	`185`	`}`
`187`	`186`	`return '';`
`@@ -190,7 +189,7 @@ function getSuffix(c: EmbeddedRegion) {`
`190`	`189`	`if (c.attributeValue) {`
`191`	`190`	`switch (c.languageId) {`
`192`	`191`	`case 'css': return '}';`
`193`		`- case 'javascript': return '};';`
	`192`	`+ case 'javascript': return ';';`
`194`	`193`	`}`
`195`	`194`	`}`
`196`	`195`	`return '';`