Have onDidChangeTab return an array

Author: lramos15

src/vs/workbench/api/common/extHostEditorTabs.ts

@@ -177,7 +177,7 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
 	readonly _serviceBrand: undefined;
 
 	private readonly _proxy: MainThreadEditorTabsShape;
-	private readonly _onDidChangeTab = new Emitter<vscode.Tab>();
+	private readonly _onDidChangeTab = new Emitter<vscode.Tab[]>();
 	private readonly _onDidChangeTabGroup = new Emitter<void>();
 	private readonly _onDidChangeActiveTabGroup = new Emitter<vscode.TabGroup>();
 
@@ -199,7 +199,7 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
 				// never changes -> simple value
 				onDidChangeTabGroup: that._onDidChangeTabGroup.event,
 				onDidChangeActiveTabGroup: that._onDidChangeActiveTabGroup.event,
-				onDidChangeTab: that._onDidChangeTab.event,
+				onDidChangeTabs: that._onDidChangeTab.event,
 				// dynamic -> getters
 				get groups() {
 					return Object.freeze(that._extHostTabGroups.map(group => group.apiObject));
@@ -284,6 +284,6 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
 			throw new Error('Update Tabs IPC call received before group creation.');
 		}
 		const tab = group.acceptTabDtoUpdate(tabDto);
-		this._onDidChangeTab.fire(tab.apiObject);
+		this._onDidChangeTab.fire([tab.apiObject]);
 	}
 }

src/vs/workbench/api/test/browser/extHostEditorTabs.test.ts

@@ -413,11 +413,11 @@ suite('ExtHostEditorTabs', function () {
 
 		const tab = extHostEditorTabs.tabGroups.groups[0].tabs[0];
 
-		const p = new Promise<vscode.Tab>(resolve => extHostEditorTabs.tabGroups.onDidChangeTab(resolve));
+		const p = new Promise<vscode.Tab[]>(resolve => extHostEditorTabs.tabGroups.onDidChangeTabs(resolve));
 
 		extHostEditorTabs.$acceptTabUpdate(12, { ...tabDto, label: 'NEW LABEL' });
 
-		const changedTab = await p;
+		const changedTab = (await p)[0];
 
 		assert.ok(tab === changedTab);
 		assert.strictEqual(changedTab.label, 'NEW LABEL');

src/vscode-dts/vscode.proposed.tabs.d.ts

@@ -54,9 +54,6 @@ declare module 'vscode' {
 	 */
 	export interface Tab {
 
-		// TODO@API consider adding:
-		// readonly index: number;
-
 		/**
 		 * The text displayed on the tab
 		 */
@@ -146,15 +143,12 @@ declare module 'vscode' {
 		/**
 		 * An {@link Event} which fires when a tab changes.
 		 */
-		// TODO@API use richer event type?
-		// TODO@API future proof: event with an array of tab-instances
-		readonly onDidChangeTab: Event<Tab>;
+		readonly onDidChangeTabs: Event<Tab[]>;
 
 		/**
 		 * An {@link Event} which fires when the active group changes.
 		 * This does not fire when the properties within the group change.
 		 */
-		// TODO@API consider to replace with onDidChangeActiveTAB (group can be inferred from that)
 		readonly onDidChangeActiveTabGroup: Event<TabGroup>;
 
 		/**