Dont require steps to be defined

Jackson Kearl · Jackson Kearl · commit 163dd4f6c0a9 · 2022-01-27T22:28:11.000-08:00
Fixes microsoft#141603
diff --git a/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedService.ts b/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedService.ts
@@ -308,7 +308,7 @@ export class WalkthroughsService extends Disposable implements IWalkthroughsServ
 
 			const isNewlyInstalled = !this.metadata.get(categoryID);
 			if (isNewlyInstalled) {
-				this.metadata.set(categoryID, { firstSeen: +new Date(), stepIDs: walkthrough.steps.map(s => s.id), manaullyOpened: false });
+				this.metadata.set(categoryID, { firstSeen: +new Date(), stepIDs: walkthrough.steps?.map(s => s.id) ?? [], manaullyOpened: false });
 			}
 
 			const override = await Promise.race([
@@ -327,8 +327,7 @@ export class WalkthroughsService extends Disposable implements IWalkthroughsServ
 				}
 			}
 
-
-			const steps = walkthrough.steps.map((step, index) => {
+			const steps = (walkthrough.steps ?? []).map((step, index) => {
 				const description = parseDescription(step.description || '');
 				const fullyQualifiedID = extension.identifier.value + '#' + walkthrough.id + '#' + step.id;
 

Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ export class WalkthroughsService extends Disposable implements IWalkthroughsServ`
`308`	`308`
`309`	`309`	`const isNewlyInstalled = !this.metadata.get(categoryID);`
`310`	`310`	`if (isNewlyInstalled) {`
`311`		`- this.metadata.set(categoryID, { firstSeen: +new Date(), stepIDs: walkthrough.steps.map(s => s.id), manaullyOpened: false });`
	`311`	`+ this.metadata.set(categoryID, { firstSeen: +new Date(), stepIDs: walkthrough.steps?.map(s => s.id) ?? [], manaullyOpened: false });`
`312`	`312`	`}`
`313`	`313`
`314`	`314`	`const override = await Promise.race([`
`@@ -327,8 +327,7 @@ export class WalkthroughsService extends Disposable implements IWalkthroughsServ`
`327`	`327`	`}`
`328`	`328`	`}`
`329`	`329`
`330`		`-`
`331`		`- const steps = walkthrough.steps.map((step, index) => {`
	`330`	`+ const steps = (walkthrough.steps ?? []).map((step, index) => {`
`332`	`331`	`const description = parseDescription(step.description \|\| '');`
`333`	`332`	`const fullyQualifiedID = extension.identifier.value + '#' + walkthrough.id + '#' + step.id;`
`334`	`333`