Skip to content

Commit 17f192d

Browse files
committed
a bunch of ugly hacks to
1) remove cycling dependencies 2) avoid `export import`
1 parent c9ec0f9 commit 17f192d

File tree

5 files changed

+26
-8
lines changed

5 files changed

+26
-8
lines changed

src/vs/base/test/node/testUtils.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,5 @@ export function getPathFromAmdModule(requirefn: typeof require, relativePath: st
1616
return URI.parse(requirefn.toUrl(relativePath)).fsPath;
1717
}
1818

19-
export import flakySuite = testUtils.flakySuite;
19+
// export import flakySuite = testUtils.flakySuite;
20+
export const flakySuite = testUtils.flakySuite;

src/vs/editor/common/tokenizationRegistry.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import { Color } from 'vs/base/common/color';
77
import { Emitter, Event } from 'vs/base/common/event';
88
import { Disposable, IDisposable, toDisposable } from 'vs/base/common/lifecycle';
9-
import { ColorId, ITokenizationRegistry, ITokenizationSupport, ITokenizationSupportChangedEvent, ITokenizationSupportFactory } from 'vs/editor/common/languages';
9+
import { ITokenizationRegistry, ITokenizationSupport, ITokenizationSupportChangedEvent, ITokenizationSupportFactory } from 'vs/editor/common/languages';
1010

1111
export class TokenizationRegistry implements ITokenizationRegistry {
1212

@@ -104,8 +104,8 @@ export class TokenizationRegistry implements ITokenizationRegistry {
104104
}
105105

106106
public getDefaultBackground(): Color | null {
107-
if (this._colorMap && this._colorMap.length > ColorId.DefaultBackground) {
108-
return this._colorMap[ColorId.DefaultBackground];
107+
if (this._colorMap && this._colorMap.length > /* ColorId.DefaultBackground */2) {
108+
return this._colorMap[/* ColorId.DefaultBackground */2];
109109
}
110110
return null;
111111
}

src/vs/editor/common/viewLayout/lineDecorations.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,17 @@
66
import * as strings from 'vs/base/common/strings';
77
import { Constants } from 'vs/base/common/uint';
88
import { InlineDecoration, InlineDecorationType } from 'vs/editor/common/viewModel';
9-
import { LinePartMetadata } from 'vs/editor/common/viewLayout/viewLineRenderer';
9+
10+
// TODO@jrieken HACK!
11+
const enum LinePartMetadata {
12+
IS_WHITESPACE = 1,
13+
PSEUDO_BEFORE = 2,
14+
PSEUDO_AFTER = 4,
15+
16+
IS_WHITESPACE_MASK = 0b001,
17+
PSEUDO_BEFORE_MASK = 0b010,
18+
PSEUDO_AFTER_MASK = 0b100,
19+
}
1020

1121
export class LineDecoration {
1222
_lineDecorationBrand: void = undefined;

src/vs/platform/notification/common/notification.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,14 @@
66
import { IAction } from 'vs/base/common/actions';
77
import { Event } from 'vs/base/common/event';
88
import { IDisposable } from 'vs/base/common/lifecycle';
9-
import BaseSeverity from 'vs/base/common/severity';
109
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
1110

12-
export import Severity = BaseSeverity;
11+
export enum Severity {
12+
Ignore = 0,
13+
Info = 1,
14+
Warning = 2,
15+
Error = 3
16+
}
1317

1418
export const INotificationService = createDecorator<INotificationService>('notificationService');
1519

src/vs/workbench/contrib/tasks/common/tasks.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ import { RawContextKey, ContextKeyExpression } from 'vs/platform/contextkey/comm
1616
import { TaskDefinitionRegistry } from 'vs/workbench/contrib/tasks/common/taskDefinitionRegistry';
1717
import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
1818
import { ConfigurationTarget } from 'vs/platform/configuration/common/configuration';
19-
import { USER_TASKS_GROUP_KEY } from 'vs/workbench/contrib/tasks/common/taskService';
19+
20+
// TODO@jrieken HACK, HACK
21+
// import { USER_TASKS_GROUP_KEY } from 'vs/workbench/contrib/tasks/common/taskService';
22+
const USER_TASKS_GROUP_KEY = 'settings';
2023

2124
export const TASK_RUNNING_STATE = new RawContextKey<boolean>('taskRunning', false, nls.localize('tasks.taskRunningContext', "Whether a task is currently running."));
2225
export const TASKS_CATEGORY = { value: nls.localize('tasksCategory', "Tasks"), original: 'Tasks' };

0 commit comments

Comments
 (0)