Avoid double encoding vscode.dev links (microsoft#181002)

joyceerhl · web-flow · commit 180f909faccf · 2023-04-27T08:48:29.000+02:00
diff --git a/extensions/github/src/commands.ts b/extensions/github/src/commands.ts
@@ -17,7 +17,7 @@ async function copyVscodeDevLink(gitAPI: GitAPI, useSelection: boolean, context:
 	try {
 		const permalink = getLink(gitAPI, useSelection, getVscodeDevHost(), 'headlink', context, includeRange);
 		if (permalink) {
-			return vscode.env.clipboard.writeText(encodeURI(permalink));
+			return vscode.env.clipboard.writeText(permalink);
 		}
 	} catch (err) {
 		vscode.window.showErrorMessage(err.message);

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ async function copyVscodeDevLink(gitAPI: GitAPI, useSelection: boolean, context:`
`17`	`17`	`try {`
`18`	`18`	`const permalink = getLink(gitAPI, useSelection, getVscodeDevHost(), 'headlink', context, includeRange);`
`19`	`19`	`if (permalink) {`
`20`		`- return vscode.env.clipboard.writeText(encodeURI(permalink));`
	`20`	`+ return vscode.env.clipboard.writeText(permalink);`
`21`	`21`	`}`
`22`	`22`	`} catch (err) {`
`23`	`23`	`vscode.window.showErrorMessage(err.message);`