Skip to content

Commit 19ca019

Browse files
committed
Diff overview ruler css variables
1 parent abfb1f6 commit 19ca019

File tree

2 files changed

+14
-31
lines changed

2 files changed

+14
-31
lines changed

src/vs/workbench/contrib/notebook/browser/diff/notebookDiff.css

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,3 +306,15 @@
306306
.notebook-text-diff-editor .notebook-overview-ruler-container .diffViewport {
307307
z-index: var(--notebook-diff-view-viewport-slider);
308308
}
309+
310+
.notebook-text-diff-editor .diffViewport {
311+
background: var(--vscode-scrollbarSlider-background);
312+
}
313+
314+
.notebook-text-diff-editor .diffViewport:hover {
315+
background: var(--vscode-scrollbarSlider-hoverBackground);
316+
}
317+
318+
.notebook-text-diff-editor .diffViewport:active {
319+
background: var(--vscode-scrollbarSlider-activeBackground);
320+
}

src/vs/workbench/contrib/notebook/browser/diff/notebookDiffOverviewRuler.ts

Lines changed: 2 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import * as DOM from 'vs/base/browser/dom';
88
import { createFastDomNode, FastDomNode } from 'vs/base/browser/fastDomNode';
99
import { Color } from 'vs/base/common/color';
1010
import { DisposableStore, IDisposable } from 'vs/base/common/lifecycle';
11-
import { defaultInsertColor, defaultRemoveColor, diffInserted, diffOverviewRulerInserted, diffOverviewRulerRemoved, diffRemoved, scrollbarSliderActiveBackground, scrollbarSliderBackground, scrollbarSliderHoverBackground } from 'vs/platform/theme/common/colorRegistry';
12-
import { IColorTheme, IThemeService, registerThemingParticipant, Themable } from 'vs/platform/theme/common/themeService';
11+
import { defaultInsertColor, defaultRemoveColor, diffInserted, diffOverviewRulerInserted, diffOverviewRulerRemoved, diffRemoved } from 'vs/platform/theme/common/colorRegistry';
12+
import { IColorTheme, IThemeService, Themable } from 'vs/platform/theme/common/themeService';
1313
import { DiffElementViewModelBase } from 'vs/workbench/contrib/notebook/browser/diff/diffElementViewModel';
1414
import { NotebookDiffEditorEventDispatcher } from 'vs/workbench/contrib/notebook/browser/diff/eventDispatcher';
1515
import { INotebookTextDiffEditor } from 'vs/workbench/contrib/notebook/browser/diff/notebookDiffEditorBrowser';
@@ -214,32 +214,3 @@ export class NotebookDiffOverviewRuler extends Themable {
214214
super.dispose();
215215
}
216216
}
217-
218-
registerThemingParticipant((theme, collector) => {
219-
const scrollbarSliderBackgroundColor = theme.getColor(scrollbarSliderBackground);
220-
if (scrollbarSliderBackgroundColor) {
221-
collector.addRule(`
222-
.notebook-text-diff-editor .diffViewport {
223-
background: ${scrollbarSliderBackgroundColor};
224-
}
225-
`);
226-
}
227-
228-
const scrollbarSliderHoverBackgroundColor = theme.getColor(scrollbarSliderHoverBackground);
229-
if (scrollbarSliderHoverBackgroundColor) {
230-
collector.addRule(`
231-
.notebook-text-diff-editor .diffViewport:hover {
232-
background: ${scrollbarSliderHoverBackgroundColor};
233-
}
234-
`);
235-
}
236-
237-
const scrollbarSliderActiveBackgroundColor = theme.getColor(scrollbarSliderActiveBackground);
238-
if (scrollbarSliderActiveBackgroundColor) {
239-
collector.addRule(`
240-
.notebook-text-diff-editor .diffViewport:active {
241-
background: ${scrollbarSliderActiveBackgroundColor};
242-
}
243-
`);
244-
}
245-
});

0 commit comments

Comments
 (0)