Voice: terminal controller is not behaving like view/inline (fix microsoft#208791) (microsoft#208800)

bpasero · web-flow · commit 1a2cc56282f0 · 2024-03-26T17:04:13.000+01:00
diff --git a/src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatController.ts b/src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatController.ts
@@ -261,6 +261,7 @@ export class TerminalChatController extends Disposable implements ITerminalContr
 				throw new Error('Could not start chat session');
 			}
 		}
+		this._messages.fire(Message.ACCEPT_INPUT);
 		const model = this._model.value;
 
 		this._lastInput = this._chatWidget?.value?.input();
@@ -326,7 +327,6 @@ export class TerminalChatController extends Disposable implements ITerminalContr
 				this._chatWidget?.value.inlineChatWidget.updateChatMessage({ message: new MarkdownString(responseContent), requestId: this._currentRequest.id, providerId: 'terminal' }, false, containsCode);
 				this._responseContainsCodeBlockContextKey.set(containsCode);
 				this._chatWidget?.value.inlineChatWidget.updateToolbar(true);
-				this._messages.fire(Message.ACCEPT_INPUT);
 			}
 			const supportIssueReporting = this._currentRequest?.response?.agent?.metadata?.supportIssueReporting;
 			if (supportIssueReporting !== undefined) {

Original file line number	Diff line number	Diff line change
`@@ -261,6 +261,7 @@ export class TerminalChatController extends Disposable implements ITerminalContr`
`261`	`261`	`throw new Error('Could not start chat session');`
`262`	`262`	`}`
`263`	`263`	`}`
	`264`	`+ this._messages.fire(Message.ACCEPT_INPUT);`
`264`	`265`	`const model = this._model.value;`
`265`	`266`
`266`	`267`	`this._lastInput = this._chatWidget?.value?.input();`
`@@ -326,7 +327,6 @@ export class TerminalChatController extends Disposable implements ITerminalContr`
`326`	`327`	`this._chatWidget?.value.inlineChatWidget.updateChatMessage({ message: new MarkdownString(responseContent), requestId: this._currentRequest.id, providerId: 'terminal' }, false, containsCode);`
`327`	`328`	`this._responseContainsCodeBlockContextKey.set(containsCode);`
`328`	`329`	`this._chatWidget?.value.inlineChatWidget.updateToolbar(true);`
`329`		`- this._messages.fire(Message.ACCEPT_INPUT);`
`330`	`330`	`}`
`331`	`331`	`const supportIssueReporting = this._currentRequest?.response?.agent?.metadata?.supportIssueReporting;`
`332`	`332`	`if (supportIssueReporting !== undefined) {`