Skip to content

Commit 1ad43ea

Browse files
committed
adding telemetry when error happens
1 parent b60b4d7 commit 1ad43ea

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/vs/editor/contrib/inlineCompletions/browser/inlineCompletionsModel.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import { mapFindFirst } from 'vs/base/common/arraysFind';
7-
import { BugIndicatingError, onUnexpectedExternalError } from 'vs/base/common/errors';
7+
import { BugIndicatingError, onUnexpectedError, onUnexpectedExternalError } from 'vs/base/common/errors';
88
import { Disposable } from 'vs/base/common/lifecycle';
99
import { IObservable, IReader, ITransaction, autorun, derived, derivedHandleChanges, derivedOpts, recomputeInitiallyAndOnChange, observableSignal, observableValue, subtransaction, transaction } from 'vs/base/common/observable';
1010
import { commonPrefixLength, splitLinesIncludeSeparators } from 'vs/base/common/strings';
@@ -421,9 +421,6 @@ export class InlineCompletionsModel extends Disposable {
421421
const partialGhostTextVal = ghostTextVal.substring(0, acceptUntilIndexExclusive);
422422

423423
const positions = this._positions.get();
424-
if (positions.length === 0) {
425-
return;
426-
}
427424
const cursorPosition = positions[0];
428425

429426
// Executing the edit might free the completion, so we have to hold a reference on it.
@@ -486,6 +483,10 @@ export function getSecondaryEdits(textModel: ITextModel, positions: readonly Pos
486483
);
487484
const positionWithinTextEdit = subtractPositions(primaryPosition, primaryEditStartPosition);
488485
if (positionWithinTextEdit.lineNumber < 1) {
486+
onUnexpectedError(new BugIndicatingError(
487+
`positionWithinTextEdit line number should be bigger than 0.
488+
Invalid subtraction between ${primaryPosition.toString()} and ${primaryEditStartPosition.toString()}`
489+
));
489490
return [];
490491
}
491492
const secondaryEditText = substringPos(primaryEdit.text, positionWithinTextEdit);

0 commit comments

Comments
 (0)