Revert "Call composition type handler when doing composition" (microsoft#251902)

Revert "Call composition type handler when doing composition (microsoft#251821)"

This reverts commit 57d591d.

Author: aiday-mar

src/vs/editor/browser/controller/editContext/native/nativeEditContext.ts

@@ -61,7 +61,7 @@ export class NativeEditContext extends AbstractEditContext {
 	private _parent: HTMLElement | undefined;
 	private _decorations: string[] = [];
 	private _primarySelection: Selection = new Selection(1, 1, 1, 1);
-	private _isComposing: boolean = false;
+
 
 	private _targetWindowId: number = -1;
 	private _scrollTop: number = 0;
@@ -185,15 +185,13 @@ export class NativeEditContext extends AbstractEditContext {
 			this._emitTypeEvent(this._viewController, e);
 		}));
 		this._register(editContextAddDisposableListener(this._editContext, 'compositionstart', (e) => {
-			this._isComposing = true;
 			// Utlimately fires onDidCompositionStart() on the editor to notify for example suggest model of composition state
 			// Updates the composition state of the cursor controller which determines behavior of typing with interceptors
 			this._viewController.compositionStart();
 			// Emits ViewCompositionStartEvent which can be depended on by ViewEventHandlers
 			this._context.viewModel.onCompositionStart();
 		}));
 		this._register(editContextAddDisposableListener(this._editContext, 'compositionend', (e) => {
-			this._isComposing = false;
 			// Utlimately fires compositionEnd() on the editor to notify for example suggest model of composition state
 			// Updates the composition state of the cursor controller which determines behavior of typing with interceptors
 			this._viewController.compositionEnd();
@@ -408,7 +406,7 @@ export class NativeEditContext extends AbstractEditContext {
 	}
 
 	private _onType(viewController: ViewController, typeInput: ITypeData): void {
-		if (typeInput.replacePrevCharCnt || typeInput.replaceNextCharCnt || typeInput.positionDelta || this._isComposing) {
+		if (typeInput.replacePrevCharCnt || typeInput.replaceNextCharCnt || typeInput.positionDelta) {
 			viewController.compositionType(typeInput.text, typeInput.replacePrevCharCnt, typeInput.replaceNextCharCnt, typeInput.positionDelta);
 		} else {
 			viewController.type(typeInput.text);

src/vs/editor/browser/widget/codeEditor/codeEditorWidget.ts

@@ -1861,8 +1861,7 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE
 				},
 				compositionType: (text: string, replacePrevCharCnt: number, replaceNextCharCnt: number, positionDelta: number) => {
 					// Try if possible to go through the existing `replacePreviousChar` command
-					const editContextEnabled = this.getOption(EditorOption.effectiveEditContext);
-					if (replaceNextCharCnt || positionDelta || editContextEnabled) {
+					if (replaceNextCharCnt || positionDelta) {
 						// must be handled through the new command
 						const payload: editorCommon.CompositionTypePayload = { text, replacePrevCharCnt, replaceNextCharCnt, positionDelta };
 						this._commandService.executeCommand(editorCommon.Handler.CompositionType, payload);