Skip to content

Commit 1e0fba6

Browse files
authored
updates api notes (microsoft#204386)
1 parent 857bfa6 commit 1e0fba6

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

src/vscode-dts/vscode.proposed.chatAgents2.d.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ declare module 'vscode' {
6464
* If the request resulted in an error, this property defines the error details.
6565
*/
6666
errorDetails?: ChatAgentErrorDetails;
67+
68+
// TODO@API
69+
// add CATCH-all signature [name:string]: string|boolean|number instead of `T extends...`
6770
}
6871

6972
/**

src/vscode-dts/vscode.proposed.chatProvider.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ declare module 'vscode' {
1010
part: string;
1111
}
1212

13+
// @API extension ship a d.ts files for their options
14+
1315
/**
1416
* Represents a large language model that accepts ChatML messages and produces a streaming response
1517
*/

src/vscode-dts/vscode.proposed.chatRequestAccess.d.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,15 @@ declare module 'vscode' {
6565
* Whether the access to chat has been revoked. This happens when the condition that allowed for
6666
* chat access doesn't hold anymore, e.g a user interaction has ended.
6767
*/
68-
isRevoked: boolean;
68+
readonly isRevoked: boolean;
69+
70+
// @API do we need an event for revocation
6971

7072
/**
7173
* The name of the model that is used for this chat access. It is expected that the model name can
7274
* be used to lookup properties like token limits and ChatML support
7375
*/
74-
model: string;
76+
readonly model: string;
7577

7678
/**
7779
* Make a chat request.
@@ -101,5 +103,9 @@ declare module 'vscode' {
101103
* @param id The id of the chat provider, e.g `copilot`
102104
*/
103105
export function requestChatAccess(id: string): Thenable<ChatAccess>;
106+
107+
//@API add those
108+
// export const chatAccesses: string[];
109+
// export const onDidChangeChatAccesses: Event<void>;
104110
}
105111
}

0 commit comments

Comments
 (0)